Skip to content

Conversation

@jakehobbs
Copy link
Contributor

@jakehobbs jakehobbs commented Nov 7, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on restructuring the wagmi examples, specifically transitioning to a new wagmi-v5-example while removing the old wagmi-core-example. It introduces new configurations, components, and dependencies, enhancing the overall structure and functionality.

Detailed summary

  • Deleted the wagmi-core-example directory and its contents.
  • Introduced wagmi-v5-example with new structure and files.
  • Added environment variables in .env.example.
  • Updated postcss.config.mjs to include Tailwind CSS.
  • Created next.config.ts for Next.js configuration.
  • Revised package.json with new dependencies.
  • Developed new components in src/app for layout and providers.
  • Added global styles in globals.css using Tailwind CSS.
  • Implemented various demos for wallet functionalities in page.tsx.
  • Enhanced ESLint configuration in eslint.config.mjs.
  • Updated TypeScript configuration in tsconfig.json.

The following files were skipped due to too many changes: yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
aa-sdk-ui-demo Ignored Ignored Preview Nov 10, 2025 6:33pm

@jakehobbs jakehobbs changed the base branch from main to moldy/v5-base November 7, 2025 17:36
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 7, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the entire ui-demo example application from the repository. The ui-demo was a comprehensive demonstration application showcasing Smart Wallets functionality with configuration options for authentication methods, styling, and wallet types.

Key Changes:

  • Complete removal of the ui-demo Next.js application
  • Deletion of all UI components, configuration files, and API routes
  • Removal of end-to-end tests and contract test files
  • Elimination of related dependencies and build configurations

Reviewed Changes

Copilot reviewed 24 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/ui-demo/src/components/* Removed all UI components including icons, modals, configuration panels, and shared components
examples/ui-demo/src/app/* Removed Next.js application files including pages, API routes, providers, and configuration
examples/ui-demo/.{json,mjs,config.} Removed build configuration files, package dependencies, and project settings
examples/ui-demo/e2e/* Removed end-to-end test specifications
examples/ui-demo/contracts/* Removed Solidity contract test files

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Nov 10, 2025, 6:34 PM

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ⌛ In Progress 🏗️ Building... Nov 7, 2025, 5:39 PM

@github-actions github-actions bot temporarily deployed to docs-preview November 7, 2025 17:39 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview November 7, 2025 17:39 Inactive
createClient,
} from "viem";
import { createConnector, type CreateConnectorFn } from "wagmi";
import { createConnector, type CreateConnectorFn } from "@wagmi/core";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"wagmi" a react-specific pkg, so we shouldn't use it in our "@alchemy/wagmi-core"

@@ -0,0 +1,518 @@
"use client";

import {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed all of our signer hooks from here

Comment on lines +24 to +28
import {
prepareCalls,
prepareSwap,
sendPreparedCalls,
} from "@alchemy/wagmi-core";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the actions directly now since we no longer provide hooks

export const config = createConfig({
connectors: [
alchemySmartWallet({
ownerConnector: injected(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using injected connector now for signer

@github-actions github-actions bot temporarily deployed to docs-preview November 7, 2025 17:49 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview November 7, 2025 17:50 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview November 7, 2025 17:54 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview November 7, 2025 17:54 Inactive
"devDependencies": {
"@commitlint/cli": "^17.6.3",
"@commitlint/config-conventional": "^17.6.3",
"@tanstack/react-query": "^5.28.9",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wish i didn't have to do this, but the example app is resolving wagmi from the monorepo root. then since wagmi requires tanstack as a peer dep, it's looking at the same level and not finding it. i think this is ok for now.

Copy link
Contributor

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakehobbs jakehobbs enabled auto-merge (squash) November 10, 2025 18:32
@github-actions github-actions bot temporarily deployed to docs-preview November 10, 2025 18:32 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview November 10, 2025 18:32 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview November 10, 2025 18:33 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview November 10, 2025 18:33 Inactive
@jakehobbs jakehobbs merged commit 9a98b5f into moldy/v5-base Nov 10, 2025
12 checks passed
@jakehobbs jakehobbs deleted the jake/wagmi-react-example-v5 branch November 10, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants