-
Notifications
You must be signed in to change notification settings - Fork 199
feat(v5): wagmi react example #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the entire ui-demo example application from the repository. The ui-demo was a comprehensive demonstration application showcasing Smart Wallets functionality with configuration options for authentication methods, styling, and wallet types.
Key Changes:
- Complete removal of the ui-demo Next.js application
- Deletion of all UI components, configuration files, and API routes
- Removal of end-to-end tests and contract test files
- Elimination of related dependencies and build configurations
Reviewed Changes
Copilot reviewed 24 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/ui-demo/src/components/* | Removed all UI components including icons, modals, configuration panels, and shared components |
| examples/ui-demo/src/app/* | Removed Next.js application files including pages, API routes, providers, and configuration |
| examples/ui-demo/.{json,mjs,config.} | Removed build configuration files, package dependencies, and project settings |
| examples/ui-demo/e2e/* | Removed end-to-end test specifications |
| examples/ui-demo/contracts/* | Removed Solidity contract test files |
🌿 Documentation Preview
|
🌿 Documentation Preview
|
| createClient, | ||
| } from "viem"; | ||
| import { createConnector, type CreateConnectorFn } from "wagmi"; | ||
| import { createConnector, type CreateConnectorFn } from "@wagmi/core"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"wagmi" a react-specific pkg, so we shouldn't use it in our "@alchemy/wagmi-core"
| @@ -0,0 +1,518 @@ | |||
| "use client"; | |||
|
|
|||
| import { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed all of our signer hooks from here
| import { | ||
| prepareCalls, | ||
| prepareSwap, | ||
| sendPreparedCalls, | ||
| } from "@alchemy/wagmi-core"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the actions directly now since we no longer provide hooks
| export const config = createConfig({ | ||
| connectors: [ | ||
| alchemySmartWallet({ | ||
| ownerConnector: injected(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using injected connector now for signer
| "devDependencies": { | ||
| "@commitlint/cli": "^17.6.3", | ||
| "@commitlint/config-conventional": "^17.6.3", | ||
| "@tanstack/react-query": "^5.28.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wish i didn't have to do this, but the example app is resolving wagmi from the monorepo root. then since wagmi requires tanstack as a peer dep, it's looking at the same level and not finding it. i think this is ok for now.
thebrianchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on restructuring the
wagmiexamples, specifically transitioning to a newwagmi-v5-examplewhile removing the oldwagmi-core-example. It introduces new configurations, components, and dependencies, enhancing the overall structure and functionality.Detailed summary
wagmi-core-exampledirectory and its contents.wagmi-v5-examplewith new structure and files..env.example.postcss.config.mjsto include Tailwind CSS.next.config.tsfor Next.js configuration.package.jsonwith new dependencies.src/appfor layout and providers.globals.cssusing Tailwind CSS.page.tsx.eslint.config.mjs.tsconfig.json.