.tool-versions and PNPM version #109
Conversation
🌿 Documentation Preview
|
| @@ -0,0 +1 @@ | |||
| nodejs 22.15.0 | |||
There was a problem hiding this comment.
For asdf or mise users, keeps us on a standard Node Version. Vercel defaults to v22. This only applies locally - it won't change what vercel uses.
| "engines": { | ||
| "node": "22.x" | ||
| }, |
There was a problem hiding this comment.
Make explicit the node version that vercel will use (this is currently the default)
package.json
Outdated
| "engines": { | ||
| "node": "22.x" | ||
| }, | ||
| "packageManager": "pnpm@10.9.0", |
There was a problem hiding this comment.
Lock the pnpm version for both us and vercel
There was a problem hiding this comment.
@ddgromit Will take a closer look at this later but FYI this isn't deploying on our Vercel. Fern have their own setup it deploys on. I believe it uses Vercel under the hood but sounds like its super custom
|
Ah I see, so if they are just hosting the build/ dir then they won't read these values anyway. Still useful for local dev and CI IMO. |
| uses: pnpm/action-setup@v4 | ||
| id: pnpm-install | ||
| with: | ||
| version: 9 |
There was a problem hiding this comment.
We should specify this no? I believe it doesn't read package.json
* Versions and corepack * Vercel engine * Github action * CI versions * Version file --------- Co-authored-by: dslovinsky <dslovinsky@users.noreply.github.com>
Description
Lock the node & pnpm versions
Testing
pnpm run validate)