Skip to content

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Removes execution gas limit efficiency check from the mempool, this hasn't been useful
  • Adds a revert check to the mempool. If either execution or postop reverts the UO will be rejected
  • Implement the revert check in the entry point in two ways:
    • using eth_simulateV1 - this should be used on most networks as its much more efficient
    • using debug_traceCall
  • Currently disabled for UOs that use aggregators due to complexities with generating the signature and PBH UOs need proxying. This can potentially be fixed in the future by switching to using simulateHandleOp instead of handleOps.

TODO

  • Switch to using simulateHandleOp and add support for aggregated user ops
  • Lots of testing in difference scenarios
  • Determine correct settings for various networks

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

❌ Patch coverage is 10.09464% with 285 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.81%. Comparing base (9af8a53) to head (e8fc7c9).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
crates/provider/src/alloy/entry_point/mod.rs 0.00% 82 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% 66 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 61 Missing ⚠️
crates/pool/src/server/remote/error.rs 0.00% 24 Missing ⚠️
crates/pool/src/mempool/uo_pool.rs 43.58% 22 Missing ⚠️
crates/rpc/src/eth/error.rs 0.00% 13 Missing ⚠️
crates/types/src/pool/error.rs 0.00% 7 Missing ⚠️
bin/rundler/src/cli/pool.rs 0.00% 3 Missing ⚠️
crates/types/src/chain.rs 50.00% 3 Missing ⚠️
crates/builder/src/bundle_sender.rs 50.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/rundler/src/cli/mod.rs 0.00% <ø> (ø)
crates/pool/src/mempool/mod.rs 100.00% <ø> (ø)
crates/provider/src/traits/entry_point.rs 80.00% <ø> (ø)
crates/provider/src/traits/test_utils.rs 100.00% <100.00%> (ø)
crates/rpc/src/eth/events/common.rs 29.59% <ø> (ø)
crates/builder/src/bundle_sender.rs 77.01% <50.00%> (-0.06%) ⬇️
crates/contracts/src/v0_7.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/pool.rs 0.00% <0.00%> (ø)
crates/types/src/chain.rs 78.03% <50.00%> (-1.34%) ⬇️
crates/types/src/pool/error.rs 0.00% <0.00%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

Flag Coverage Δ
unit-tests 59.81% <10.09%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 74.76% <50.00%> (-0.79%) ⬇️
dev ∅ <ø> (∅)
pool 66.33% <26.98%> (-0.36%) ⬇️
provider 23.86% <4.56%> (-1.40%) ⬇️
rpc 28.96% <0.00%> (-0.14%) ⬇️
sim 82.06% <ø> (+0.32%) ⬆️
tasks ∅ <ø> (∅)
types 69.80% <23.07%> (+0.15%) ⬆️
utils 33.87% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dancoombs
Copy link
Collaborator Author

Looks like we need to update the geth version in the 06 compliance tests

@dancoombs dancoombs changed the title feat: add revert check to mempool entry feat: add revert check to mempool add Jul 8, 2025
@github-actions github-actions bot added the stale label Aug 8, 2025
@github-actions github-actions bot closed this Aug 14, 2025
@dancoombs dancoombs reopened this Aug 22, 2025
@dancoombs dancoombs added prevent-stale Prevent an issue from closure due to being stale and removed stale labels Aug 22, 2025
@github-actions github-actions bot added the stale label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prevent-stale Prevent an issue from closure due to being stale stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant