fix(flashbots): sign keccak256(body) bytes for x-flashbots-signature #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozirDmitriy
requested review from
dancoombs,
dphilipson,
0xfourzerofour,
alex-miao and
andysim3d
as code owners
|
Is this fix in response to a particular bug? Did something change in the Flashbots signature expectation? I believe this code has generally worked in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Flashbots signing to use EIP-191 over the 32-byte keccak256 hash of the JSON request body instead of signing the ASCII hex string. This aligns with Flashbots relay expectations (equivalent to signMessage(arrayify(keccak256(body))) in ethers), improves compatibility, and avoids signatures being rejected by the relay. No behavior changes elsewhere. Lints pass.