Skip to content

Commit 06f4606

Browse files
ohadzeligerohadzeliger
committed
Triage rest of files, add to annotations
1 parent d0d9c56 commit 06f4606

11 files changed

+159
-136
lines changed

‎yaml-tests/src/test/resources/create-drop.yamsql

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ setup:
148148
connect: "jdbc:embed:/__SYS?schema=CATALOG"
149149
steps:
150150
- query: drop database if exists /frl/db
151-
# 4.1 triage: Fails with force continuations (but not for snapshot)
151+
# 4.1 triage: [Initial version] Fails with force continuations (but not for snapshot)
152152
# Embedded -> 4.0.559.6:
153153
# expected: <false> but was: <true>
154154
# org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
@@ -158,13 +158,14 @@ setup:
158158
# 4.0.559.6 -> Embedded:
159159
# Received continuation shouldn't be at beginning
160160
#---
161-
#test_block:
162-
# connect: "jdbc:embed:/__SYS?schema=CATALOG"
163-
# preset: single_repetition_ordered
164-
# tests:
165-
# -
166-
# - query: select count(*) from "DATABASES" where database_id = '/FRL/DB'
167-
# - result: [{0}]
161+
test_block:
162+
connect: "jdbc:embed:/__SYS?schema=CATALOG"
163+
preset: single_repetition_ordered
164+
tests:
165+
-
166+
- query: select count(*) from "DATABASES" where database_id = '/FRL/DB'
167+
- maxRows: 0
168+
- result: [{0}]
168169
---
169170
setup:
170171
connect: "jdbc:embed:/__SYS?schema=CATALOG"

‎yaml-tests/src/test/resources/enum.yamsql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
# See the License for the specific language governing permissions and
1818
# limitations under the License.
1919

20-
# 4.1-triage: enum support was not added to client until 4.1.6.0, none of these queries pass, all with:
20+
# 4.1-triage: [Ignored: Enum] enum support was not added to client until 4.1.6.0, none of these queries pass, all with:
2121
# The comparand to a comparison expecting an argument of a primitive type, is invoked with an argument of a complex type, e.g. an array or a record.
2222
---
2323
options:

‎yaml-tests/src/test/resources/functions.yamsql

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,11 @@ test_block:
9292
-
9393
- query: select least(a1, a2, a8), least(1, 2, 3.0, 4, 5) from A
9494
- result: [{_0: 1.0, _1: 1.0}]
95-
# 4.1 triage: Fails with force continuations for all versions with (including snapshot):
96-
# cannot continue query due to mismatch between serialized and actual plan hash
97-
# -
98-
# - query: select coalesce(null, null, 5), coalesce(null, 1, null), coalesce(null, a1, a8) from A
99-
# - result: [{_0: 5, _1: 1, _2: 1.0}]
95+
# 4.1 triage: [Deferred: literal null issue] Fails with force continuations for all versions with (including snapshot): cannot continue query due to mismatch between serialized and actual plan hash
96+
-
97+
- query: select coalesce(null, null, 5), coalesce(null, 1, null), coalesce(null, a1, a8) from A
98+
- maxRows: 0
99+
- result: [{_0: 5, _1: 1, _2: 1.0}]
100100
-
101101
- query: select b1, b2, coalesce(b1, b2, 42) from B
102102
- unorderedResult: [
@@ -125,15 +125,15 @@ test_block:
125125
{{ T1: 3, A: 'c', B: 3.0}},
126126
{{ T1: 4, A: 'd', B: 4.0}},
127127
{!null _}]
128-
# 4.1 triage: Fails with force continuations for all versions with (including snapshot):
129-
# cannot continue query due to mismatch between serialized and actual plan hash
130-
# -
131-
# - query: select coalesce(null, (1, 1.0, 'a', true)) from C
132-
# - unorderedResult: [
133-
# {{ _0: 1, _1: 1.0, _2: 'a', _3: true}},
134-
# {{ _0: 1, _1: 1.0, _2: 'a', _3: true}},
135-
# {{ _0: 1, _1: 1.0, _2: 'a', _3: true}},
136-
# {{ _0: 1, _1: 1.0, _2: 'a', _3: true}}]
128+
# 4.1 triage: [Deferred: literal null issue] Fails with force continuations for all versions with (including snapshot): cannot continue query due to mismatch between serialized and actual plan hash
129+
-
130+
- query: select coalesce(null, (1, 1.0, 'a', true)) from C
131+
- maxRows: 0
132+
- unorderedResult: [
133+
{{ _0: 1, _1: 1.0, _2: 'a', _3: true}},
134+
{{ _0: 1, _1: 1.0, _2: 'a', _3: true}},
135+
{{ _0: 1, _1: 1.0, _2: 'a', _3: true}},
136+
{{ _0: 1, _1: 1.0, _2: 'a', _3: true}}]
137137
---
138138
test_block:
139139
preset: single_repetition_ordered

‎yaml-tests/src/test/resources/groupby-tests.yamsql

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,19 +142,23 @@ test_block:
142142
# -
143143
# - query: select COUNT(x.col2) from (select col1,col2 from t1) as x group by x.col1;
144144
# - result: [{!l 5}, {!l 8}]
145-
# 4.1 Triage: Test failed when run with forced continuations (Result mismatch)
146-
# -
147-
# - query: select AVG(x.col2) from (select col1,col2 from t1) as x group by x.col1;
148-
# - result: [{3.0}, {9.5}]
145+
# 4.1 Triage: [Investigate further] Test failed when run with forced continuations (Result mismatch)
146+
# [4.0.559.6, !currentVersion] returned 10.0 instead of 9.5
147+
-
148+
- query: select AVG(x.col2) from (select col1,col2 from t1) as x group by x.col1;
149+
- maxRows: 0
150+
- result: [{3.0}, {9.5}]
149151
# 4.1 Triage: Test failed when run with forced continuations (Caused by: com.google.common.base.VerifyException)
150152
# -
151153
# - query: select SUM(x.col2) from (select col1,col2 from t1) as x group by x.col1;
152154
# - result: [{!l 15}, {!l 76}]
153-
# 4.1 Triage: Test failed when run with forced continuations (Result mismatch)
154-
# -
155+
# 4.1 Triage: [Investigate further] Test failed when run with forced continuations (Result mismatch)
156+
# [4.0.559.6, !currentVersion] returned {10, 10.0} instead of {9, 9.5}
157+
-
155158
# result is correct since we don't use (not support, yet) explicit casting.
156-
# - query: select SUM(x.col2) / COUNT(x.col2), AVG(x.col2) from (select col1,col2 from t1) as x group by x.col1;
157-
# - result: [{!l 3, 3.0}, {!l 9, 9.5}]
159+
- query: select SUM(x.col2) / COUNT(x.col2), AVG(x.col2) from (select col1,col2 from t1) as x group by x.col1;
160+
- maxRows: 0
161+
- result: [{!l 3, 3.0}, {!l 9, 9.5}]
158162
-
159163
- query: select MAX(x.col2) from (select col1 from t1) as x group by x.col1;
160164
- error: "42703"

‎yaml-tests/src/test/resources/insert-enum.yamsql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1717
# See the License for the specific language governing permissions and
1818
# limitations under the License.
19-
# 4.1-triage: Enum support wasn't added until 4.1.6.0 All tests fail to insert enums with:
19+
# 4.1-triage: [Ignored: Enum] Enum support wasn't added until 4.1.6.0 All tests fail to insert enums with:
2020
# Caused by: java.sql.SQLException: java.sql.Type=1111 not supported
2121
---
2222
options:

‎yaml-tests/src/test/resources/inserts-updates-deletes.yamsql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,12 @@ test_block:
105105
- result: [{ B1: 10, B2: 22, B3: { 5, 41 } },
106106
{ B1: 20, B2: 22, B3: { 6, 51 } },
107107
{ B1: 30, B2: 22, B3: { 7, 61 } } ]
108-
# 4.1 Triage: failed when running against 4.0.559.6 (expecting '42601' error code, got 'XXXXX' instead)
108+
# 4.1 Triage: [Initial version] failed when running against 4.0.559.6 ("expecting '42601' error code, got 'XXXXX' instead" and "java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1")
109109
# -
110110
# Case where not all values are provided of A. Still works, since the columns for which no values are provided can be nullable.
111111
# - query: insert into A(A1, A2, A3) values (4);
112112
# - error: "42601"
113-
# 4.1 Triage: Failed when initial version is 4.0.559.6 (expecting statement to throw an error, however it returned a count)
113+
# 4.1 Triage: [Initial version] Failed when initial version is 4.0.559.6 (expecting statement to throw an error, however it returned a count)
114114
# -
115115
# Case when the number of values is more than the number of columns specified.
116116
# - query: insert into A(A1, A2, A3) values (5, 6, 7, 8, 9);

‎yaml-tests/src/test/resources/join-tests.yamsql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ test_block:
6767
-
6868
# Get names of people working on a project
6969
- query: select fname, lname from emp where exists (select * from project where emp_id = emp.id);
70-
# 4.1 Triage: This runs into infinite loop
70+
# 4.1 Triage: [Investigate further: Exists subquery] This runs into infinite loop
7171
- maxRows: 0
7272
- unorderedResult: [{"Emily", "Martinez"},
7373
{"Daniel", "Miller"},
@@ -78,7 +78,7 @@ test_block:
7878
(select fname, lname, dept_id from emp where exists (select * from project where emp_id = emp.id)) as sq,
7979
dept
8080
where sq.dept_id = dept.id and dept.name = 'Sales';
81-
# 4.1 Triage: This runs into infinite loop
81+
# 4.1 Triage: [Investigate further: Exists subquery] This runs into infinite loop
8282
- maxRows: 0
8383
- unorderedResult: [{"Daniel", "Miller"}]
8484
-

‎yaml-tests/src/test/resources/like.yamsql

Lines changed: 104 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
# See the License for the specific language governing permissions and
1818
# limitations under the License.
1919

20-
# 4.1 triage: All queries that return any results, fail with force continuations, even against current version
20+
# 4.1 triage: [Deferred: like continuations] All queries that return any results, fail with force continuations, even against current version
2121
# with: The like operator expects an escape character of length 1.
2222
---
2323
schema_template:
@@ -52,107 +52,123 @@ test_block:
5252
-
5353
- query: select * from A WHERE A1 LIKE '%abc'
5454
- result: []
55-
# -
56-
# - query: select * from A WHERE A1 LIKE '%abc%'
57-
# - unorderedResult: [
58-
# {'abcdefghijklmnopqrstuvwxyz'},
59-
# {'___abcdef'},
60-
# {'%%abcdef'},
61-
# {'*abcdef'},
62-
# {'(abcdefghijk)'},
63-
# {'[abcdefghijk]'},
64-
# {'{abcdefghijk}'}]
65-
# -
66-
# - query: select * from A WHERE A1 LIKE '_abc%'
67-
# - unorderedResult: [
68-
# {'(abcdefghijk)'},
69-
# {'[abcdefghijk]'},
70-
# {'{abcdefghijk}'},
71-
# {'*abcdef'}]
72-
# -
73-
# # TODO (Investigate `Missing binding for __const_CONSTANT` error with queries when using plan from cache)
74-
# - query: select * from A WHERE A1 LIKE '%ABC%'
75-
# - unorderedResult: [{'ABCDEFGHIJKLMNOPQRSTUVWXYZ'}]
76-
# -
77-
# - query: select * from A WHERE A1 LIKE '%ABC%X_Z'
78-
# - unorderedResult: [{'ABCDEFGHIJKLMNOPQRSTUVWXYZ'}]
55+
-
56+
- query: select * from A WHERE A1 LIKE '%abc%'
57+
- maxRows: 0
58+
- unorderedResult: [
59+
{'abcdefghijklmnopqrstuvwxyz'},
60+
{'___abcdef'},
61+
{'%%abcdef'},
62+
{'*abcdef'},
63+
{'(abcdefghijk)'},
64+
{'[abcdefghijk]'},
65+
{'{abcdefghijk}'}]
66+
-
67+
- query: select * from A WHERE A1 LIKE '_abc%'
68+
- maxRows: 0
69+
- unorderedResult: [
70+
{'(abcdefghijk)'},
71+
{'[abcdefghijk]'},
72+
{'{abcdefghijk}'},
73+
{'*abcdef'}]
74+
-
75+
# TODO (Investigate `Missing binding for __const_CONSTANT` error with queries when using plan from cache)
76+
- query: select * from A WHERE A1 LIKE '%ABC%'
77+
- maxRows: 0
78+
- unorderedResult: [{'ABCDEFGHIJKLMNOPQRSTUVWXYZ'}]
79+
-
80+
- query: select * from A WHERE A1 LIKE '%ABC%X_Z'
81+
- maxRows: 0
82+
- unorderedResult: [{'ABCDEFGHIJKLMNOPQRSTUVWXYZ'}]
7983
-
8084
- query: select * from A WHERE A1 LIKE '%ABC%XY_Z'
8185
- unorderedResult: []
82-
# -
83-
# - query: select * from A WHERE A1 LIKE '__'
84-
# - unorderedResult: [
85-
# {'学校'},
86-
# {'^$'}]
87-
# -
88-
# - query: select * from A WHERE A1 LIKE '_____'
89-
# - unorderedResult: [
90-
# {'école'},
91-
# {'ありがとう'},
92-
# {'مدرسة'},
93-
# {'\\||%'}]
86+
-
87+
- query: select * from A WHERE A1 LIKE '__'
88+
- maxRows: 0
89+
- unorderedResult: [
90+
{'学校'},
91+
{'^$'}]
92+
-
93+
- query: select * from A WHERE A1 LIKE '_____'
94+
- maxRows: 0
95+
- unorderedResult: [
96+
{'école'},
97+
{'ありがとう'},
98+
{'مدرسة'},
99+
{'\\||%'}]
94100
---
95101
# TODO (Investigate `Missing binding for __const_CONSTANT` error with queries when using plan from cache)
96102
test_block:
97103
options:
98104
repetition: 1
99105
check_cache: false
100106
tests:
101-
# -
102-
# - query: select * from A WHERE A1 LIKE '|_|_%' ESCAPE '|'
103-
# - result: [{'___abcdef'}]
104-
# -
105-
# - query: select * from A WHERE A1 LIKE '\_%' ESCAPE '\'
106-
# - result: [{'___abcdef'}]
107-
# -
108-
# - query: select * from A WHERE A1 LIKE '\_%' ESCAPE '|'
109-
# - result: [{'\\||%'}]
110-
# -
111-
# - query: select * from A WHERE A1 LIKE '\_%'
112-
# - result: [{'\\||%'}]
113-
# -
114-
# - query: select * from A WHERE A1 LIKE '\_\_\_abcdef' ESCAPE '\'
115-
# - result: [{'___abcdef'}]
116-
# -
117-
# - query: select * from A WHERE A1 LIKE '\_\_\_______' ESCAPE '\'
118-
# - result: [{'___abcdef'}]
119-
# -
120-
# - query: select * from A WHERE A1 LIKE '\__\_______' ESCAPE '\'
121-
# - result: [{'___abcdef'}]
107+
-
108+
- query: select * from A WHERE A1 LIKE '|_|_%' ESCAPE '|'
109+
- maxRows: 0
110+
- result: [{'___abcdef'}]
111+
-
112+
- query: select * from A WHERE A1 LIKE '\_%' ESCAPE '\'
113+
- maxRows: 0
114+
- result: [{'___abcdef'}]
115+
-
116+
- query: select * from A WHERE A1 LIKE '\_%' ESCAPE '|'
117+
- maxRows: 0
118+
- result: [{'\\||%'}]
119+
-
120+
- query: select * from A WHERE A1 LIKE '\_%'
121+
- maxRows: 0
122+
- result: [{'\\||%'}]
123+
-
124+
- query: select * from A WHERE A1 LIKE '\_\_\_abcdef' ESCAPE '\'
125+
- maxRows: 0
126+
- result: [{'___abcdef'}]
127+
-
128+
- query: select * from A WHERE A1 LIKE '\_\_\_______' ESCAPE '\'
129+
- maxRows: 0
130+
- result: [{'___abcdef'}]
131+
-
132+
- query: select * from A WHERE A1 LIKE '\__\_______' ESCAPE '\'
133+
- maxRows: 0
134+
- result: [{'___abcdef'}]
122135
-
123136
- query: select * from A WHERE A1 LIKE '\__\______\_' ESCAPE '\'
124137
- result: []
125-
# -
126-
# - query: select * from A WHERE A1 LIKE '%\%' ESCAPE '\'
127-
# - result: [{'\\||%'}]
128-
# -
129-
# - query: select * from A WHERE A1 NOT LIKE '|_|_%' ESCAPE '|'
130-
# - unorderedResult: [
131-
# {'abcdefghijklmnopqrstuvwxyz'},
132-
# {'%%abcdef'},
133-
# {'*abcdef'},
134-
# {'ABCDEFGHIJKLMNOPQRSTUVWXYZ'},
135-
# {'école'},
136-
# {'ありがとう'},
137-
# {'学校'},
138-
# {'مدرسة'},
139-
# {'(abcdefghijk)'},
140-
# {'[abcdefghijk]'},
141-
# {'{abcdefghijk}'},
142-
# {'^$'},
143-
# {'\\||%'}
144-
# ]
138+
-
139+
- query: select * from A WHERE A1 LIKE '%\%' ESCAPE '\'
140+
- maxRows: 0
141+
- result: [{'\\||%'}]
142+
-
143+
- query: select * from A WHERE A1 NOT LIKE '|_|_%' ESCAPE '|'
144+
- maxRows: 0
145+
- unorderedResult: [
146+
{'abcdefghijklmnopqrstuvwxyz'},
147+
{'%%abcdef'},
148+
{'*abcdef'},
149+
{'ABCDEFGHIJKLMNOPQRSTUVWXYZ'},
150+
{'école'},
151+
{'ありがとう'},
152+
{'学校'},
153+
{'مدرسة'},
154+
{'(abcdefghijk)'},
155+
{'[abcdefghijk]'},
156+
{'{abcdefghijk}'},
157+
{'^$'},
158+
{'\\||%'}
159+
]
145160
-
146161
- query: select * from A WHERE A1 NOT LIKE '%'
147162
- unorderedResult: []
148-
# -
149-
# - query: select * from A WHERE A1 NOT LIKE '%abcde%'
150-
# - unorderedResult: [
151-
# {'ABCDEFGHIJKLMNOPQRSTUVWXYZ'},
152-
# {'école'},
153-
# {'ありがとう'},
154-
# {'学校'},
155-
# {'مدرسة'},
156-
# {'^$'},
157-
# {'\\||%'} ]
163+
-
164+
- query: select * from A WHERE A1 NOT LIKE '%abcde%'
165+
- maxRows: 0
166+
- unorderedResult: [
167+
{'ABCDEFGHIJKLMNOPQRSTUVWXYZ'},
168+
{'école'},
169+
{'ありがとう'},
170+
{'学校'},
171+
{'مدرسة'},
172+
{'^$'},
173+
{'\\||%'} ]
158174
...

‎yaml-tests/src/test/resources/select-a-star.yamsql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ test_block:
4040
tests:
4141
-
4242
- query: select B1 from B where exists (select A.*, B1 from A group by A1,A2,A3);
43-
# 4.1 Triage: Infinite loop
43+
# 4.1 Triage: [Investigate further: Exists subquery] Infinite loop
4444
- maxRows: 0
4545
- result: [{1}, {2}, {3}]
4646
-
@@ -80,12 +80,12 @@ test_block:
8080
- error: "42803"
8181
-
8282
- query: select B1 from B where exists (select A.*, B1 from A group by A1,A2,A3);
83-
# 4.1 Triage: Infinite loop
83+
# 4.1 Triage: [Investigate further: Exists subquery] Infinite loop
8484
- maxRows: 0
8585
- result: [{1}, {2}, {3}]
8686
-
8787
- query: select B.* from B where exists (select A.*, B.* from A group by A1,A2,A3);
88-
# 4.1 Triage: Infinite loop
88+
# 4.1 Triage: [Investigate further: Exists subquery] Infinite loop
8989
- maxRows: 0
9090
- result: [{1, 20, {4, 40}},
9191
{2, 20, {5, 50}},

0 commit comments

Comments
 (0)