Skip to content

Commit c1fa486

Browse files
committed
Triage:
- Received continuation shouldn't be at beginning - Initial version
1 parent fc09ed9 commit c1fa486

12 files changed

+94
-74
lines changed

yaml-tests/src/test/resources/aggregate-index-tests-count-empty.yamsql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ test_block:
3333
-
3434
- query: select count(*) from t1
3535
- explain: "AISCAN(MV1 <,> BY_GROUP -> [_0: VALUE:[0]]) | MAP (_ AS _0) | ON EMPTY NULL | MAP (coalesce_long(_._0._0, promote(0l AS LONG)) AS _0)"
36-
# 4.1 Triage: failing when running against 4.0.559.6 (result mismatch)
36+
# 4.1 Triage: [No Fix Necessary] failing when running against 4.0.559.6 (result mismatch)
37+
# Triage Note: 4.2.9.0 to 4.0.559.6 works correctly, need to write a test to verify
3738
# - result: [{0}]
3839
-
3940
- query: select count(*) from t1 group by col2

yaml-tests/src/test/resources/bitmap-aggregate-index.yamsql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,12 @@ test_block:
7070
-
7171
- query: SELECT bitmap_construct_agg(bitmap_bit_position(id)) as bitmap, bitmap_bucket_offset(id) as offset FROM T2 GROUP BY bitmap_bucket_offset(id)
7272
- explain: "ISCAN(AGG_INDEX_1 <,>) | MAP (_ AS _0) | AGG (bitmap_construct_agg_l((_._0.ID) bitmap_bit_position 10000) AS _0) GROUP BY ((_._0.ID) bitmap_bucket_offset 10000 AS _0) | MAP (_._1._0 AS BITMAP, _._0._0 AS OFFSET)"
73-
# 4.1 Triage: this fails with continuation tests against 4.0.559.6. Wrong results
73+
# 4.1 Triage: [Initial version] this fails with continuation tests against 4.0.559.6. Wrong results
7474
# - unorderedResult: [{BITMAP: xStartsWith_1250'060000c', 'OFFSET':0}, {BITMAP: xStartsWith_1250'02', 'OFFSET':10000}]
7575
-
7676
- query: SELECT bitmap_construct_agg(bitmap_bit_position(id)) as bitmap, category, bitmap_bucket_offset(id) as offset FROM T2 GROUP BY category, bitmap_bucket_offset(id)
7777
- explain: "ISCAN(AGG_INDEX_2 <,>) | MAP (_ AS _0) | AGG (bitmap_construct_agg_l((_._0.ID) bitmap_bit_position 10000) AS _0) GROUP BY (_._0.CATEGORY AS _0, (_._0.ID) bitmap_bucket_offset 10000 AS _1) | MAP (_._1._0 AS BITMAP, _._0._0 AS CATEGORY, _._0._1 AS OFFSET)"
78-
# 4.1 Triage: this fails with continuation tests against 4.0.559.6. Wrong results
78+
# 4.1 Triage: [Initial version] this fails with continuation tests against 4.0.559.6. Wrong results
7979
# - unorderedResult: [{BITMAP: xStartsWith_1250'0200004', 'CATEGORY': 'hello', 'OFFSET':0},
8080
# {BITMAP: xStartsWith_1250'02', 'CATEGORY': 'hello', 'OFFSET':10000},
8181
# {BITMAP: xStartsWith_1250'0400008', 'CATEGORY': 'world', 'OFFSET':0}]

yaml-tests/src/test/resources/boolean.yamsql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ test_block:
9494
-
9595
- query: select B AND FALSE from lb
9696
- result: [ { false }, { false }, { false } ]
97-
# 4.1 Triage: failing when running with forced continuations (cannot continue query due to mismatch between serialized and actual plan hash)
97+
# 4.1 Triage: [Deferred: literal null issue] failing when running with forced continuations (cannot continue query due to mismatch between serialized and actual plan hash)
9898
# -
9999
# - query: select B AND NULL from lb
100100
# - result: [ { !null }, { false }, { !null } ]
@@ -104,7 +104,7 @@ test_block:
104104
-
105105
- query: select B OR FALSE from lb
106106
- result: [ { true }, { false }, { !null } ]
107-
# 4.1 Triage: failing when running with forced continuations (cannot continue query due to mismatch between serialized and actual plan hash)
107+
# 4.1 Triage: [Deferred: literal null issue] failing when running with forced continuations (cannot continue query due to mismatch between serialized and actual plan hash)
108108
# -
109109
# - query: select B OR NULL from lb
110110
# - result: [ { true }, { !null }, { !null } ]

yaml-tests/src/test/resources/catalog.yamsql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ test_block:
5858
- query: select sum(cnt) from (select count(*) as cnt, template_name, template_version from schemas
5959
group by template_name, template_version having template_name = 't') as t;
6060
- explainContains: 'AISCAN(TEMPLATES_COUNT_INDEX'
61-
# 4.1 Triage: failing when running with forced continuations (Received continuation shouldn't be at beginning)
61+
# 4.1 Triage: [Deferred: Not failing in CK] failing when running with forced continuations (Received continuation shouldn't be at beginning)
6262
# -
6363
# - query: select sum(cnt) from (select count(*) as cnt, template_name, template_version from schemas
6464
# group by template_name, template_version having template_name = 'TEST_TEMPLATE_1') as t;
@@ -68,7 +68,7 @@ test_block:
6868
- query: select sum(cnt) from (select count(*) as cnt, template_name, template_version from schemas
6969
group by template_name, template_version having template_name = 't' and template_version = 1) as t;
7070
- explainContains: 'AISCAN(TEMPLATES_COUNT_INDEX'
71-
# 4.1 Triage: failing when running with forced continuations (Received continuation shouldn't be at beginning)
71+
# 4.1 Triage: [Deferred: Not failing in CK] failing when running with forced continuations (Received continuation shouldn't be at beginning)
7272
# -
7373
# - query: select sum(cnt) from (select count(*) as cnt, template_name, template_version from schemas
7474
# group by template_name, template_version having template_name = 'TEST_TEMPLATE_1' and template_version = 1) as t;

yaml-tests/src/test/resources/create-drop.yamsql

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ setup:
4444
- query: drop database if exists /frl/DB
4545
- query: create schema template temp1 create table T1(a1 bigint, primary key(a1))
4646

47-
# 4.1 triage: Fails with force continuations for all versions with:
47+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations for all versions with:
4848
# Received continuation shouldn't be at beginning
4949
#---
5050
#test_block:
@@ -59,9 +59,10 @@ setup:
5959
connect: "jdbc:embed:/__SYS?schema=CATALOG"
6060
steps:
6161
- query: drop schema template temp1
62-
# 4.1 triage: Fails with force continuations (Does not fail with SNAPSHOT)
62+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations (Does not fail with SNAPSHOT)
6363
# Embedded -> 4.0.559.6:
6464
# Received continuation shouldn't be at beginning
65+
# 4.1 Triage: fails with force continuations (Does not fail with SNAPSHOT)
6566
# 4.0.559.6 -> Embedded:
6667
# expected: <false> but was: <true>
6768
# org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
@@ -80,7 +81,7 @@ setup:
8081
connect: "jdbc:embed:/__SYS?schema=CATALOG"
8182
steps:
8283
- query: create schema template temp2 create table T1(a1 bigint, primary key(a1))
83-
# 4.1 triage: Fails with force continuations for all versions (including SNAPSHOT):
84+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations for all versions (including SNAPSHOT):
8485
# Received continuation shouldn't be at beginning
8586
#---
8687
#test_block:
@@ -95,7 +96,7 @@ setup:
9596
connect: "jdbc:embed:/__SYS?schema=CATALOG"
9697
steps:
9798
- query: create database /frl/db
98-
# 4.1 triage: Fails with force continuations for all versions (including SNAPSHOT):
99+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations for all versions (including SNAPSHOT):
99100
# Received continuation shouldn't be at beginning
100101
#---
101102
#test_block:
@@ -110,9 +111,10 @@ setup:
110111
connect: "jdbc:embed:/__SYS?schema=CATALOG"
111112
steps:
112113
- query: drop database /frl/db
113-
# 4.1 triage: Fails with force continuations (but not for snapshot)
114+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations (but not for snapshot)
114115
# Embedded -> 4.0.559.6:
115116
# Received continuation shouldn't be at beginning
117+
# 4.1 triage: Fails with force continuations (but not for snapshot)
116118
# 4.0.559.6 -> Embedded:
117119
# expected: <false> but was: <true>
118120
# org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
@@ -131,7 +133,7 @@ setup:
131133
connect: "jdbc:embed:/__SYS?schema=CATALOG"
132134
steps:
133135
- query: create database /frl/db
134-
# 4.1 triage: Fails with force continuations for all versions (including SNAPSHOT):
136+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations for all versions (including SNAPSHOT):
135137
# Received continuation shouldn't be at beginning
136138
#---
137139
#test_block:
@@ -152,6 +154,7 @@ setup:
152154
# org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
153155
# at app//com.apple.foundationdb.relational.yamltests.command.QueryExecutor.executeStatementWithForcedContinuations(QueryExecutor.java:258)
154156
# at app//com.apple.foundationdb.relational.yamltests.command.QueryExecutor.executeStatementAndCheckForceContinuations(QueryExecutor.java:219)
157+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations (but not for snapshot)
155158
# 4.0.559.6 -> Embedded:
156159
# Received continuation shouldn't be at beginning
157160
#---
@@ -167,7 +170,7 @@ setup:
167170
connect: "jdbc:embed:/__SYS?schema=CATALOG"
168171
steps:
169172
- query: create database /frl/db
170-
# 4.1 triage: Fails with force continuations for all versions (including SNAPSHOT):
173+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations for all versions (including SNAPSHOT):
171174
# Received continuation shouldn't be at beginning
172175
#---
173176
#test_block:
@@ -182,7 +185,7 @@ setup:
182185
connect: "jdbc:embed:/__SYS?schema=CATALOG"
183186
steps:
184187
- query: create schema /frl/db/s1 with template temp2
185-
# 4.1 triage: Fails with force continuations for all versions (including SNAPSHOT):
188+
# 4.1 triage: [Deferred: Not failing in CK] Fails with force continuations for all versions (including SNAPSHOT):
186189
# Received continuation shouldn't be at beginning
187190
#---
188191
#test_block:
@@ -197,9 +200,10 @@ setup:
197200
connect: "jdbc:embed:/__SYS?schema=CATALOG"
198201
steps:
199202
- query: drop database /frl/db
200-
# 4.1 triage: Both queries fail with force continuations (but not for snapshot)
203+
# 4.1 triage: [Deferred: Not failing in CK] Both queries fail with force continuations (but not for snapshot)
201204
# Embedded -> 4.0.559.6:
202205
# Received continuation shouldn't be at beginning
206+
# 4.1 triage: Both queries fail with force continuations (but not for snapshot)
203207
# 4.0.559.6 -> Embedded:
204208
# expected: <false> but was: <true>
205209
# org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
@@ -224,7 +228,7 @@ setup:
224228
- query: create database /frl/db
225229
- query: create schema /frl/db/s1 with template temp2
226230
- query: create schema /frl/db/s2 with template temp2
227-
# 4.1 triage: Both queries fail with force continuations for all versions (including SNAPSHOT):
231+
# 4.1 triage: [Deferred: Not failing in CK] Both queries fail with force continuations for all versions (including SNAPSHOT):
228232
# Received continuation shouldn't be at beginning
229233
#---
230234
#test_block:
@@ -242,9 +246,10 @@ setup:
242246
connect: "jdbc:embed:/__SYS?schema=CATALOG"
243247
steps:
244248
- query: drop database /frl/db
245-
# 4.1 triage: Both queries fail with force continuations (but not for snapshot)
249+
# 4.1 triage: [Deferred: Not failing in CK] Both queries fail with force continuations (but not for snapshot)
246250
# Embedded -> 4.0.559.6:
247251
# Received continuation shouldn't be at beginning
252+
# 4.1 triage: Both queries fail with force continuations (but not for snapshot)
248253
# 4.0.559.6 -> Embedded:
249254
# expected: <false> but was: <true>
250255
# org.opentest4j.AssertionFailedError: expected: <false> but was: <true>

yaml-tests/src/test/resources/field-index-tests-proto.yamsql

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,21 +56,24 @@ test_block:
5656
-
5757
- query: select * from (select * from (select * from "MyTable") as x) as y where ID = 5;
5858
- result: [{ID: !l 5, COL1: !l 10, COL31: !l 5, COL32: !null _, COL2: !l 5}]
59-
# 4.1 Triage: failed when running with forced continuations (Received continuation shouldn't be at beginning)
60-
# -
61-
# - query: select count(*) from (select * from (select * from (select * from "MyTable" where ID = 5) as x) as y) as z;
62-
# - result: [{!l 1}]
59+
# 4.1 Triage: [Deferred: Not failing in CK] failed when running with forced continuations (Received continuation shouldn't be at beginning)
60+
-
61+
- query: select count(*) from (select * from (select * from (select * from "MyTable" where ID = 5) as x) as y) as z;
62+
- maxRows: 0
63+
- result: [{!l 1}]
6364
-
6465
- query: select COL31, COL32 from (select * from (select * from "MyTable") as x) as y where ID = 5;
6566
- result: [{COL31: !l 5, COL32: !null _}]
66-
# 4.1 Triage: failed when running with forced continuations (Received continuation shouldn't be at beginning)
67-
# -
68-
# - query: select sum(COL1) from "MyTable";
69-
# - result: [{!l 210}]
70-
# 4.1 Triage: failed when running with forced continuations (Received continuation shouldn't be at beginning)
71-
# -
72-
# - query: select count(COL1) from "MyTable";
73-
# - result: [{!l 13}]
67+
# 4.1 Triage: [Deferred: Not failing in CK] failed when running with forced continuations (Received continuation shouldn't be at beginning)
68+
-
69+
- query: select sum(COL1) from "MyTable";
70+
- maxRows: 0
71+
- result: [{!l 210}]
72+
# 4.1 Triage: [Deferred: Not failing in CK] failed when running with forced continuations (Received continuation shouldn't be at beginning)
73+
-
74+
- query: select count(COL1) from "MyTable";
75+
- maxRows: 0
76+
- result: [{!l 13}]
7477
-
7578
- query: select * from (select * from (select * from (select * from "MyTable" where ID > 10) as x) as y) as z;
7679
- result: [{ID: !l 11, COL1: !l 20, COL31: !null _, COL32: !l 12, COL2: !l 11},

yaml-tests/src/test/resources/groupby-tests.yamsql

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -161,22 +161,26 @@ test_block:
161161
-
162162
- query: select X.col2 from (select col1, col2 from t1) as x group by x.col1;
163163
- error: "42803"
164-
# 4.1 Triage: Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
165-
# -
166-
# - query: select MAX(x.col2) from (select col1,col2 from t1) as x;
167-
# - result: [{!l 13}]
168-
# 4.1 Triage: Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
169-
# -
170-
# - query: select MIN(x.col2) from (select col1,col2 from t1) as x;
171-
# - result: [{!l 1}]
172-
# 4.1 Triage: Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
173-
# -
174-
# - query: select COUNT(x.col2) from (select col1,col2 from t1) as x;
175-
# - result: [{!l 13}]
176-
# 4.1 Triage: Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
177-
# -
178-
# - query: select AVG(x.col2) from (select col1,col2 from t1) as x;
179-
# - result: [{7.0}]
164+
# 4.1 Triage: [Deferred: Not failing in CK] Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
165+
-
166+
- query: select MAX(x.col2) from (select col1,col2 from t1) as x;
167+
- maxRows: 0
168+
- result: [{!l 13}]
169+
# 4.1 Triage: [Deferred: Not failing in CK] Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
170+
-
171+
- query: select MIN(x.col2) from (select col1,col2 from t1) as x;
172+
- maxRows: 0
173+
- result: [{!l 1}]
174+
# 4.1 Triage: [Deferred: Not failing in CK] Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
175+
-
176+
- query: select COUNT(x.col2) from (select col1,col2 from t1) as x;
177+
- maxRows: 0
178+
- result: [{!l 13}]
179+
# 4.1 Triage: [Deferred: Not failing in CK] Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
180+
-
181+
- query: select AVG(x.col2) from (select col1,col2 from t1) as x;
182+
- maxRows: 0
183+
- result: [{7.0}]
180184
-
181185
- query: select x.col1 + 10 from (select col1 from t1) as x group by x.col1;
182186
- result: [{!l 20}, {!l 30}]
@@ -194,14 +198,16 @@ test_block:
194198
# -
195199
# - query: select G + 4 from (select MIN(x.col2) as G from (select col1,col2 from t1) as x group by x.col1 as K) as Y where G > 5;
196200
# - result: [{!l 10}]
197-
# 4.1 Triage: Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
198-
# -
199-
# - query: select COUNT(*) from T1;
200-
# - result: [{!l 13}]
201-
# 4.1 Triage: Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
202-
# -
203-
# - query: select COUNT(col1) from T1;
204-
# - result: [{!l 13}]
201+
# 4.1 Triage: [Deferred: Not failing in CK] Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
202+
-
203+
- query: select COUNT(*) from T1;
204+
- maxRows: 0
205+
- result: [{!l 13}]
206+
# 4.1 Triage: [Deferred: Not failing in CK] Test failed when run with forced continuations (Received continuation shouldn't be at beginning)
207+
-
208+
- query: select COUNT(col1) from T1;
209+
- maxRows: 0
210+
- result: [{!l 13}]
205211
-
206212
- query: select x from t1 group by col1 as x, col2 as x;
207213
- error: "42702"

yaml-tests/src/test/resources/null-operator-tests.yamsql

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,11 @@ test_block:
4545
-
4646
- query: select * from (select * from (select * from T1) as x where ID is null) as y;
4747
- result: []
48-
# 4.1 Triage: failed when running with forced continuations (Received continuation shouldn't be at beginning)
49-
# -
50-
# - query: select count(*) from (select * from (select * from T1) as x where ID is not null) as y;
51-
# - unorderedResult: [{13}]
48+
# 4.1 Triage: [Deferred: Not failing in CK] failed when running with forced continuations (Received continuation shouldn't be at beginning)
49+
-
50+
- query: select count(*) from (select * from (select * from T1) as x where ID is not null) as y;
51+
- maxRows: 0
52+
- unorderedResult: [{13}]
5253
# -
5354
# - query: select count(*) from (select * from (select * from T1) as x where ID != null) as y;
5455
# - unorderedResult: [{13}]

yaml-tests/src/test/resources/primary-key-tests.yamsql

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,11 @@ test_block:
3131
VALUES ((1, 2, 3, 4), 5),
3232
((1, 2, 30, 40), 50)
3333
- error: "23505"
34-
# 4.1 Triage: failed when running with forced continuations against 4.0.559.6 (Received continuation shouldn't be at beginning)
35-
# -
36-
# - query: SELECT COUNT(*) FROM T1
37-
# - result: [{0}]
34+
# 4.1 Triage: [Deferred: Not failing in CK] failed when running with forced continuations against 4.0.559.6 (Received continuation shouldn't be at beginning)
35+
-
36+
- query: SELECT COUNT(*) FROM T1
37+
- maxRows: 0
38+
- result: [{0}]
3839
-
3940
- query: INSERT INTO T1
4041
VALUES ((1, 2, 3, 4), 5),

yaml-tests/src/test/resources/standard-tests-metadata.yamsql

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,11 @@ test_block:
5656
-
5757
- query: select * from (select * from (select * from T1) as x) as y where ID = 5;
5858
- result: [{ID: !l 5, !l 10, !l 5}]
59-
# 4.1 Triage: failed running with forced continuations (Received continuation shouldn't be at beginning)
60-
# -
61-
# - query: select count(*) from (select * from (select * from (select * from T1 where ID = 5) as x) as y) as z;
62-
# - result: [{!l 1}]
59+
# 4.1 Triage: [Deferred: Not failing in CK] failed running with forced continuations (Received continuation shouldn't be at beginning)
60+
-
61+
- query: select count(*) from (select * from (select * from (select * from T1 where ID = 5) as x) as y) as z;
62+
- maxRows: 0
63+
- result: [{!l 1}]
6364
-
6465
- query: select * from (select * from (select * from (select * from T1 where ID > 10) as x) as y) as z;
6566
- result: [{ID: !l 11, !l 20, !l 11}, {ID: !l 12, !l 20, !l 12}, {ID: !l 13, !l 20, !l 13}]

0 commit comments

Comments
 (0)