Change "children" prop to optional. #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the Microsoft SSO login functionality to provide the user with a choice between the default login button and the custom component. The current version of the application enforces the use of the custom component for Microsoft SSO login, despite the presence of a default button. This update removes this limitation and enables the user to select their preferred login method. By providing the user with the option to choose between the default button and the custom component, we increase the flexibility and usability of the application. Users who prefer the default login button can continue to use it, while those who require the additional functionality of the custom component can select that instead. This change is expected to improve the overall user experience and make the application more accessible to a wider audience.
thecuvii
approved these changes
Jul 19, 2023
|
is it gonna be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Microsoft SSO login functionality to provide the user with a choice between the default login button and the custom component. The current version of the application enforces the use of the custom component for Microsoft SSO login, despite the presence of a default button. This update removes this limitation and enables the user to select their preferred login method.
By providing the user with the option to choose between the default button and the custom component, we increase the flexibility and usability of the application. Users who prefer the default login button can continue to use it, while those who require the additional functionality of the custom component can select that instead.
This change is expected to improve the overall user experience and make the application more accessible to a wider audience.