-
Notifications
You must be signed in to change notification settings - Fork 566
Add new whisky-based recipe: Penicillin cocktail #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: alfg <702541+alfg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some changes.
src/recipes/penicillin.json
Outdated
{ | ||
"name": "Penicillin", | ||
"description": "A modern classic whisky cocktail created by Sam Ross, combining Scotch whisky with honey, lemon, and ginger for a perfect balance of sweet, sour, and spicy flavors.", | ||
"github": "assistant", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use your github user "copilot" for this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use "copilot" for the github field. (45d18b1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide an image that is 600x400px in size? Per the contribution.md guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resized the image to 600x400px as specified in the contribution guidelines. (45d18b1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a new image without stretching the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced the stretched image with a new 600x400px cocktail illustration that maintains proper proportions without distortion. The new image shows a rocks glass with amber liquid, ice, and ginger garnish themed for the Penicillin cocktail. (bc37d5b)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use another realistic image of the drink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced the illustration with a realistic cocktail image showing a whisky-based drink with ginger elements, maintaining the required 600x400px dimensions. (87019fb)
Co-authored-by: alfg <702541+alfg@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
… illustration Co-authored-by: alfg <702541+alfg@users.noreply.github.com>
Co-authored-by: alfg <702541+alfg@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Thanks! |
This PR adds a new whisky-based recipe to the OpenDrinks collection: the Penicillin cocktail.
What's Added
src/recipes/penicillin.json
- A modern classic whisky cocktail created by Sam Rosssrc/assets/recipes/penicillin.jpg
- Recipe image (600x400px JPG format)Recipe Details
The Penicillin is a contemporary whisky cocktail that combines:
This cocktail offers a perfect balance of sweet, sour, and spicy flavors with the smoky complexity of Scotch whisky.
Validation
scripts/validate_recipes.js
Contributing Guidelines Compliance
This submission follows all guidelines from
CONTRIBUTING.md
:💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.