Skip to content
This repository was archived by the owner on Jan 31, 2022. It is now read-only.

searchDisjunctiveFaceting's response does not follow the specs #485

Open
PLNech opened this issue Dec 1, 2017 · 3 comments
Open

searchDisjunctiveFaceting's response does not follow the specs #485

PLNech opened this issue Dec 1, 2017 · 3 comments

Comments

@PLNech
Copy link
Member

PLNech commented Dec 1, 2017

A customer on support reported that ISA's addFacetRefinement used with isDisjunctiveFacet=true does return hits with only the selected facet values.

He's mostly right: the documented parameter facets is returned with the currently refined facets, while the disjunctive facet values are returned in the undocumented disjunctiveFacets parameters.

Compare with IS-iOS using the swift client, which follows the specification:
facets contain disjunctive values

I see two potential solutions:

  • If we consider that having both attributes brings value (and I believe so), we should open the conversation with the other API client maintainers to return both results for disjunctive faceting queries
  • If we consider this is useless, we should update the client to put disjunctive facets in facets (keeping the disjunctiveFacets attribute for BC until the next major version).
@PLNech
Copy link
Member Author

PLNech commented Dec 1, 2017

@clement-leprovost, I would love your opinion on this. 🙂

@PLNech
Copy link
Member Author

PLNech commented May 28, 2018

@clement-leprovost, What's your take on this one? 😁

@clement-leprovost
Copy link
Contributor

Sorry, no real opinion... 😬

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants