Skip to content

[bug]: Return type mismatches in SearchClient #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magicsunday opened this issue Mar 19, 2025 · 0 comments
Open

[bug]: Return type mismatches in SearchClient #749

magicsunday opened this issue Mar 19, 2025 · 0 comments

Comments

@magicsunday
Copy link

Description

The following error is shown here only as an example for the deleteIndex method. It also affects all other methods, as far as I can see.

According to PHPDoc, deleteIndex returns array<string, mixed>|DeletedAtResponse, but in fact sendRequest returns the response of the handleResponse method (ApiWrapper.php), which is an array and not an object. Therefore, the deleteIndex method never returns the described object of type DeletedAtResponse, making it impossible to call valid, for example, to check whether the response was successful or not.

Client

Search

Version

latest

Relevant log output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant