-
Notifications
You must be signed in to change notification settings - Fork 21
docs(abtests) v3 api #4394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(abtests) v3 api #4394
Conversation
🪓 The generated code will be pushed at the end of the CI.Action triggered by commit Please do not push any generated code to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a first pass - we can make adjustments after we get a base established too!
Hello @Niamsy, this is the first time that we have a new api version in the repo, how would like it to distribute it ? |
Hello @millotp, we're planning to support both v2 and v3 in parallel. As for the distribution, I'm not sure, maybe @cdhawke has a better idea. |
@millotp - you might know better how to separate these. We will support both versions, and the only thing changing outside of the request signatures/objects will be the |
Hi @millotp, we'll soon want to release abtests v3 and merge this PR. As mentioned previously, we will support both v2 and v3 in parallel. Can we just merge this PR when we're ready or do we need to do specific things before ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful
items: | ||
$ref: "#/ABTest" | ||
- type: "null" | ||
description: No A/B tests are configured for this application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: No A/B tests are configured for this application. |
it will just represent the nullable
attribute in the doc/clients, no descriptions are expected
Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
… values in variant schema
… get/list responses
f7b6b99
to
a7654a2
Compare
🧭 What and Why
🎟 JIRA Ticket: OPTIM-1443
OPTIM-1456
OPTIM-1535
Changes included:
🧪 Test