Skip to content

Conversation

@shortcuts
Copy link
Member

@shortcuts shortcuts commented Apr 24, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3995

Changes included:

follow up of #4394, generates the client for javascript

also update the script and templates to remove the client-specific options (e.g. isFullComposition, if composition etc.) in order to leverage the variable from the client config directly

@shortcuts shortcuts self-assigned this Apr 24, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 24, 2025

✔️ Code generated!

Name Link
🪓 Triggered by bd14a130a355e3c295f0c0484afb916184fd81be
🍃 Generated commit 4bf6bfafc779932e5c9dbab68b1ab9ff224ed8e5
🌲 Generated branch generated/feat/javascript-abtesting-v3-alpha
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1699
javascript 1644
php 1478
csharp 1269
python 1097
java 1043
ruby 809
swift 589
scala 23

@shortcuts shortcuts force-pushed the feat/javascript-abtesting-v3-alpha branch from 9ea5afd to dab114a Compare April 24, 2025 14:56
@shortcuts shortcuts changed the title Feat/javascript abtesting v3 alpha feat(javascript): generate abtesting v3 alpha client Apr 24, 2025
@shortcuts shortcuts force-pushed the feat/javascript-abtesting-v3-alpha branch from dab114a to 8ae8ffb Compare July 4, 2025 13:32
Base automatically changed from docs/abtests/api-v3 to main July 4, 2025 13:47
@shortcuts shortcuts force-pushed the feat/javascript-abtesting-v3-alpha branch from d403e42 to a257ae6 Compare July 4, 2025 15:19
@shortcuts shortcuts force-pushed the feat/javascript-abtesting-v3-alpha branch from 76df050 to d2f5351 Compare July 4, 2025 16:21
@shortcuts shortcuts marked this pull request as ready for review July 7, 2025 10:02
@shortcuts shortcuts requested a review from a team as a code owner July 7, 2025 10:02
@shortcuts shortcuts requested review from millotp and morganleroi July 7, 2025 10:02
Copy link
Contributor

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great !

@shortcuts shortcuts enabled auto-merge (squash) July 7, 2025 12:22
@shortcuts shortcuts merged commit fd5dcdf into main Jul 7, 2025
53 of 56 checks passed
@shortcuts shortcuts deleted the feat/javascript-abtesting-v3-alpha branch July 7, 2025 12:55
algolia-bot added a commit that referenced this pull request Jul 7, 2025
…ed) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 7, 2025
algolia/api-clients-automation#4783

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants