fix(insights): disable events auto sending by default (#406)

* fix(insights): disable events auto sending by default

* fix tests

Author: aallam

instantsearch/src/commonMain/kotlin/com/algolia/instantsearch/searcher/hits/HitsSearcher.kt

@@ -77,7 +77,7 @@ public fun HitsSearcher(
     coroutineScope: CoroutineScope = SearcherScope(),
     coroutineDispatcher: CoroutineDispatcher = defaultDispatcher,
     triggerSearchFor: SearchForQuery = SearchForQuery.All,
-    isAutoSendingHitsViewEvents: Boolean = true,
+    isAutoSendingHitsViewEvents: Boolean = false,
     userToken: UserToken = UserToken.anonymous(),
 ): HitsSearcher = DefaultHitsSearcher(
     searchService = DefaultHitsSearchService(client),
@@ -117,7 +117,7 @@ public fun HitsSearcher(
     coroutineScope: CoroutineScope = SearcherScope(),
     coroutineDispatcher: CoroutineDispatcher = defaultDispatcher,
     triggerSearchFor: SearchForQuery = SearchForQuery.All,
-    isAutoSendingHitsViewEvents: Boolean = true,
+    isAutoSendingHitsViewEvents: Boolean = false,
     userToken: UserToken = UserToken.anonymous(),
 ): HitsSearcher = HitsSearcher(
     client = ClientSearch(applicationID, apiKey),
@@ -149,7 +149,7 @@ public fun MultiSearcher.addHitsSearcher(
     requestOptions: RequestOptions? = null,
     isDisjunctiveFacetingEnabled: Boolean = true,
     triggerSearchFor: SearchForQuery = SearchForQuery.All,
-    isAutoSendingHitsViewEvents: Boolean = true,
+    isAutoSendingHitsViewEvents: Boolean = false,
     userToken: UserToken = UserToken.anonymous(),
 ): HitsSearcher {
     return DefaultHitsSearcher(

instantsearch/src/commonTest/kotlin/searcher/Extensions.kt

@@ -22,12 +22,14 @@ fun TestSearcherSingle(
     indexName: IndexName,
     insights: ClientInsights = ClientInsights(client.applicationID, client.apiKey),
     coroutineScope: CoroutineScope = TestCoroutineScope,
+    isAutoSendingHitsViewEvents: Boolean = false,
 ) = HitsSearcher(
     client = client,
     insights = insights,
     indexName = indexName,
     isDisjunctiveFacetingEnabled = false,
-    coroutineScope = coroutineScope
+    coroutineScope = coroutineScope,
+    isAutoSendingHitsViewEvents = isAutoSendingHitsViewEvents,
 )
 
 fun TestSearcherForFacets(client: ClientSearch, indexName: IndexName, attribute: Attribute) = FacetsSearcher(

instantsearch/src/commonTest/kotlin/searcher/TestSearcherSingleIndex.kt

@@ -98,7 +98,13 @@ class TestSearcherSingleIndex {
             )
         }
         val searcher =
-            TestSearcherSingle(mockClient(mockSearchEngine), indexName, mockClientInsights(mockInsightsEngine), this)
+            TestSearcherSingle(
+                client = mockClient(mockSearchEngine),
+                indexName = indexName,
+                insights = mockClientInsights(mockInsightsEngine),
+                coroutineScope = this,
+                isAutoSendingHitsViewEvents = true,
+            )
         searcher.searchAsync().join()
         userToken.startsWith("anonymous-").shouldBeTrue()
         fetchedObjectIDs shouldEqual listOf("\"obj1\"", "\"obj2\"", "\"obj3\"")
@@ -131,7 +137,13 @@ class TestSearcherSingleIndex {
             )
         }
         val searcher =
-            TestSearcherSingle(mockClient(mockSearchEngine), indexName, mockClientInsights(mockInsightsEngine), this)
+            TestSearcherSingle(
+                client = mockClient(mockSearchEngine),
+                indexName = indexName,
+                insights = mockClientInsights(mockInsightsEngine),
+                coroutineScope = this,
+                isAutoSendingHitsViewEvents = true,
+            )
 
         searcher.searchAsync().join()
         eventsCount shouldEqual 2
@@ -163,7 +175,13 @@ class TestSearcherSingleIndex {
             )
         }
         val searcher =
-            TestSearcherSingle(mockClient(mockSearchEngine), indexName, mockClientInsights(mockInsightsEngine), this)
+            TestSearcherSingle(
+                client = mockClient(mockSearchEngine),
+                indexName = indexName,
+                insights = mockClientInsights(mockInsightsEngine),
+                coroutineScope = this,
+                isAutoSendingHitsViewEvents = true,
+            )
         searcher.isAutoSendingHitsViewEvents = false
         searcher.searchAsync().join()
         calledInsights.shouldBeFalse()
@@ -197,11 +215,16 @@ class TestSearcherSingleIndex {
             )
         }
         val searcher =
-            TestSearcherSingle(mockClient(mockSearchEngine), indexName, mockClientInsights(mockInsightsEngine), this)
+            TestSearcherSingle(
+                client = mockClient(mockSearchEngine),
+                indexName = indexName,
+                insights = mockClientInsights(mockInsightsEngine),
+                coroutineScope = this,
+                isAutoSendingHitsViewEvents = true,
+            )
         searcher.userToken = UserToken("my-user-token");
         searcher.searchAsync().join()
 
         userToken shouldEqual "my-user-token"
     }
-
 }