-
Notifications
You must be signed in to change notification settings - Fork 61
Feat: adds clear function to HitsSource #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NicFontana
wants to merge
8
commits into
algolia:master
Choose a base branch
from
NicFontana:feat/hits-source-clear-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f5cdd67
Feat: add clear support to HitsSource
d7234b5
Apply suggestions from code review
NicFontana 1f2ecf3
Refactor: remove clear method from `HitsSource`
3c359d4
Fix: HitsList SwiftUI Previews
5db5853
Style: fix indentation in HitsList Preview
5a499ff
Feat: clear paginator's memory when showItemsOnEmptyQuery is set to f…
8709e16
Merge branch 'master' into feat/hits-source-clear-support
c3a7367
Fix: HitsList previews compiler directive
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,13 +71,46 @@ | |
#if os(iOS) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By removing this conditional compiling clause, you make it fail while compiling for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, my bad. Fixed |
||
@available(iOS 13.0, tvOS 13.0, watchOS 7.0, *) | ||
struct HitsView_Previews: PreviewProvider { | ||
|
||
struct PreviewRecord<Value: Codable>: Codable { | ||
let objectID: ObjectID | ||
let value: Value | ||
|
||
init(_ value: Value, objectID: ObjectID = ObjectID(rawValue: UUID().uuidString)) { | ||
self.value = value | ||
self.objectID = objectID | ||
} | ||
|
||
static func withValue(_ value: Value) -> Self { | ||
.init(value) | ||
} | ||
} | ||
|
||
static let rawHits: Data = """ | ||
{ | ||
"hits": [ | ||
{ | ||
"objectID": "1", | ||
"value": "h1" | ||
}, | ||
{ | ||
"objectID": "2", | ||
"value": "h2" | ||
} | ||
] | ||
} | ||
""".data(using: .utf8)! | ||
|
||
static let hitsController: HitsObservableController<PreviewRecord<String>> = .init() | ||
|
||
static let interactor = HitsInteractor<PreviewRecord<String>>(infiniteScrolling: .off, showItemsOnEmptyQuery: true) | ||
|
||
static var previews: some View { | ||
let hitsController: HitsObservableController<String> = .init() | ||
NavigationView { | ||
HitsList(hitsController) { string, _ in | ||
VStack { | ||
HStack { | ||
Text(string ?? "---") | ||
Text(string?.value ?? "---") | ||
.frame(maxWidth: .infinity, minHeight: 30, maxHeight: .infinity, alignment: .leading) | ||
.padding(.horizontal, 16) | ||
} | ||
|
@@ -88,20 +121,30 @@ | |
} | ||
.padding(.top, 20) | ||
.onAppear { | ||
hitsController.hits = ["One", "Two", "Three"] | ||
}.navigationBarTitle("Hits") | ||
hitsController.hitsSource = interactor | ||
|
||
let results = try! JSONDecoder().decode(SearchResponse.self, from: rawHits) | ||
|
||
interactor.onResultsUpdated.subscribe(with: hitsController) { (reb, hit) in | ||
reb.reload() | ||
} | ||
interactor.update(results) | ||
} | ||
.navigationBarTitle("Hits") | ||
} | ||
|
||
NavigationView { | ||
HitsList(hitsController) { string, _ in | ||
VStack { | ||
HStack { | ||
Text(string ?? "---") | ||
Text(string?.value ?? "---") | ||
} | ||
Divider() | ||
} | ||
} noResults: { | ||
Text("No results") | ||
}.navigationBarTitle("Hits") | ||
} | ||
.navigationBarTitle("Hits") | ||
} | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is set from the
InstantSearchCore
module, so it cannot be declared asprivate(set)
without compilation failure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have any compilation failure targeting macOS and iOS. Am I missing something?