Skip to content

Conversation

cusma
Copy link
Contributor

@cusma cusma commented Sep 24, 2025

No description provided.

@cusma cusma requested review from giuliop and nullun September 24, 2025 16:37
@cusma cusma self-assigned this Sep 24, 2025
@cusma cusma added enhancement New feature or request fix labels Sep 24, 2025
@cusma cusma linked an issue Sep 24, 2025 that may be closed by this pull request
@cusma cusma removed the fix label Sep 24, 2025
nullun
nullun previously approved these changes Sep 25, 2025
Copy link
Contributor

@nullun nullun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions, but I can see mermaid rendering in the deployment 🎉

build:
context: .
target: release # build the release stage
platform: linux/amd64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this can still be run on a Mac M-Series device using ARM? It just won't be native and as fast?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

Comment on lines +67 to +70
RUN useradd --create-home --shell /bin/bash appuser
RUN chown -R appuser:appuser /book
RUN chmod 644 /etc/puppeteer-config.json
USER appuser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a requirement of running mdbook, or a way to start a new bash environment? It doesn't look like puppeteer-config.json specifies any particular user. Oh, maybe it's just so it's run as a non-root user?

@cusma cusma changed the base branch from develop to master October 14, 2025 14:01
@cusma cusma dismissed nullun’s stale review October 14, 2025 14:01

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add pandoc mermaid-filter

2 participants