feat: Feature/refactor time&jsonprocessor #1000
Conversation
|
|
|
@VLSMB hello, if you have time, please help me review the code |
I recommend that all Services in the jsonprocessor-tool could leverage the methods from the JsonParseTool in the common module. For any methods not currently existing in JsonParseTool, you may implement them directly within it. |
yuluo-yx
changed the title
github-actions
bot
added
area/tools
…ssor' into feature/refactor-time&jsonprocessor
@VLSMB hello, I have already made the modifications, please help me review them again |
|
|
||
| <dependency> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> |
There was a problem hiding this comment.
Hello, since the existing JsonParseTool already utilizes the Jackson deserialization library, we do not recommend introducing the Gson library. In fact, one of the goals of this issue is to unify the deserialization libraries. Please migrate all Gson usages to Jackson.
| * @author 北极星 | ||
| */ | ||
| public class JsonInsertService implements Function<JsonInsertService.JsonInsertRequest, Object> { | ||
| public class JsonProcessorInsertService implements Function<JsonProcessorInsertService.JsonInsertRequest, Object> { |
There was a problem hiding this comment.
Take it as an example, you can first use the existing public String setFieldValue(String json, String fieldName, String value) method in JsonPraseTool to obtain the processed JSON string, then convert it to Jackson's JsonNode using jsonToObject(String json, JsonNode.class) and return it. You can directly call these two functions, or write a JsonNode setFieldValue(String json, String fieldName, String value) method within JsonPraseTool. The other codes are the same.
...-calling-time/src/main/java/com/alibaba/cloud/ai/toolcalling/time/TimeAutoConfiguration.java
Outdated
Show resolved
Hide resolved
okay, I will revise it according to your suggestion |
…ssor' into feature/refactor-time&jsonprocessor
# Conflicts: # community/tool-calls/spring-ai-alibaba-starter-tool-calling-jsonprocessor/src/main/java/com/alibaba/cloud/ai/toolcalling/jsonprocessor/JsonAutoConfiguration.java # community/tool-calls/spring-ai-alibaba-starter-tool-calling-time/src/main/java/com/alibaba/cloud/ai/toolcalling/time/TimeAutoConfiguration.java
|
|
hi @fengluo97 pls fix ci. |
|
Hello, you need to run |
…ssor' into feature/refactor-time&jsonprocessor
@VLSMB Thank you for the reminder. I have already made the necessary changes. Could you please help me take a look again |
Describe what this PR does / why we need it
Completed refactoring and optimization of the spring ai alibaba starter tool rolling jsonprocessor module and spring ai alibaba starter tool rolling time module.
Does this pull request fix one issue?
For issue #849.
Describe how you did it
Refactor the code according to the specifications in the completed module and RAEDME file.
Describe how to verify it
Run the unit test code in the test package.
Special notes for reviews
NONE