Skip to content

Conversation

sincerity-being
Copy link
Collaborator

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added the area/graph SAA Grpah module label Jun 5, 2025
<dependency>
<groupId>com.github.docker-java</groupId>
<artifactId>docker-java</artifactId>
<version>3.3.3</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use style xml define <version>${fastjson.version}</version> version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented Jun 8, 2025

hi @sincerity-being pls take a look conflicts

@sincerity-being
Copy link
Collaborator Author

hi @sincerity-being pls take a look conflicts

@yuluo-yx fix

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented Jun 8, 2025

the ut and linter ci is error, 👀

@sincerity-being
Copy link
Collaborator Author

the ut and linter ci is error, 👀

execute this code need to set the path of com.alibaba.fastjson
image

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented Jun 9, 2025

I think there shouldn't be dependencies like fastjson in the project, maybe we can delete or refactor this test?
@sincerity-being

@sincerity-being
Copy link
Collaborator Author

sincerity-being commented Jun 10, 2025

I think there shouldn't be dependencies like fastjson in the project, maybe we can delete or refactor this test? @sincerity-being
image
if not this jar, jdk has self json jar or other function? this execute result must json. code execute main focus on python in open source, java code is less, this function is not elegant, if you hava better idea, I will follow it. it focus on how to writte this template to adapt this code node.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ Aias00
✅ sincerity-being
✅ chickenlj
✅ yuluo-yx
❌ Ntisok
You have signed the CLA already but the status is still pending? Let us recheck it.

@yuluo-yx yuluo-yx merged commit 54363e7 into main Jun 11, 2025
13 of 14 checks passed
@yuluo-yx yuluo-yx deleted the hyq_update branch June 11, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graph SAA Grpah module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants