Skip to content

fix(core): add blank-text validation in TextDocumentParser #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2025
Merged

fix(core): add blank-text validation in TextDocumentParser #2237

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1abc31e
fix: import IOException
6mmLIU Aug 25, 2025
820558a
fix-bugs
6mmLIU Aug 25, 2025
2a425ad
style: apply Spring JavaFormat (core) & validate studio-server on JDK17
6mmLIU Aug 25, 2025
d243903
Merge branch 'alibaba:main' into main
6mmLIU Aug 28, 2025
f654f85
Merge branch 'main' into main
yuluo-yx Aug 30, 2025
e9a3ca3
Update comments to English in TextDocumentParser
6mmLIU Aug 30, 2025
76fc264
Update comments to English in test cases
6mmLIU Aug 30, 2025
fe0f414
style(core): apply spring-javaformat to TextDocumentParser(+tests)
6mmLIU Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions spring-ai-alibaba-core/src/main/java/com/alibaba/cloud/ai/document/TextDocumentParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import org.springframework.ai.document.Document;
import org.springframework.util.Assert;

import java.io.IOException;
import java.io.InputStream;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
Expand All @@ -44,13 +45,16 @@ public TextDocumentParser(Charset charset) {
@Override
public List<Document> parse(InputStream inputStream) {
try {
String text = new String(inputStream.readAllBytes(), charset);
// 读取入口流所有文本，且使用指定的字符集解码
String text = new String(inputStream.readAllBytes(), this.charset);
// 如果文本全部为空白，则报告非法参数异常
if (text.isBlank()) {
throw new Exception();
throw new IllegalArgumentException("text must not be blank");
}
return Collections.singletonList(new Document(text));
}
catch (Exception e) {
catch (IOException e) {
// 将任何 IO 异常转换为 RuntimeException 以便传播
throw new RuntimeException(e);
}
}
Expand Down
12 changes: 4 additions & 8 deletions ...-ai-alibaba-core/src/test/java/com/alibaba/cloud/ai/document/TextDocumentParserTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,24 +62,20 @@ void testParseWithCustomCharset() {

@Test
void testParseEmptyText() {
// Test parsing empty text should throw exception
// 空字符串应当触发 IllegalArgumentException
String text = "";
TextDocumentParser parser = new TextDocumentParser();

RuntimeException exception = assertThrows(RuntimeException.class, () -> parser.parse(toInputStream(text)));

assertThat(exception).hasRootCauseInstanceOf(Exception.class);
assertThrows(IllegalArgumentException.class, () -> parser.parse(toInputStream(text)));
}

@Test
void testParseBlankText() {
// Test parsing blank text (only whitespace) should throw exception
// 含有空格或插入字符的空白字符串同样应抛出 IllegalArgumentException
String text = " \n\t ";
TextDocumentParser parser = new TextDocumentParser();

RuntimeException exception = assertThrows(RuntimeException.class, () -> parser.parse(toInputStream(text)));

assertThat(exception).hasRootCauseInstanceOf(Exception.class);
assertThrows(IllegalArgumentException.class, () -> parser.parse(toInputStream(text)));
}

@Test
Expand Down
Loading