-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support observability of saa studio #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chickenlj
merged 17 commits into
alibaba:studio-dev
from
Cirilla-zmh:lumian/fix_arms_observation
Sep 9, 2025
Merged
Support observability of saa studio #2358
chickenlj
merged 17 commits into
alibaba:studio-dev
from
Cirilla-zmh:lumian/fix_arms_observation
Sep 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 在 BaseNl2SqlService 和 BaseSchemaService 中 - 添加对 agentId 进行 trim 并检查是否为空的逻辑 - 避免因空的 agentId 导致的潜在错误或异常
- 将数据库查询结果转换类型从 boolean 改为 Boolean
…SL and enhance them for Dify DSL (alibaba#2336) * refactor: use default upload-method (local-file) * feat: support studio dsl LLMNode * fix: fix studio LLM Node * fix: fix dify LLM Node * feat: init KnowledgeRetrievalNode for Studio DSL * feat: add NodeSection.resourceFiles Method * fix bugs * feat: support generate KnowledgeRetrievalNode code with local Resources * fix styles * fix front end bugs * fix bugs * fix bugs
Sunrisea
reviewed
Sep 9, 2025
ChatOptions options = context.getRequest().getOptions(); | ||
if (options instanceof OpenAiChatOptions) { | ||
Map<String, String> metadata = ((OpenAiChatOptions) options).getMetadata(); | ||
if (metadata != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是写死的OpenAIChatOptions?是否应该抽象出一个MetaDataAwareOption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
临时方案 cc @chickenlj
chickenlj
pushed a commit
to chickenlj/spring-ai-alibaba
that referenced
this pull request
Sep 17, 2025
chickenlj
pushed a commit
that referenced
this pull request
Sep 19, 2025
co63oc
pushed a commit
to co63oc/spring-ai-alibaba
that referenced
this pull request
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
SAA Core module
area/graph
SAA Grpah module
area/nl2sql
SAA nl2sql module
area/studio
SAA Studio module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews