refactor(studio): improve date parsing error handling #2384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: improve date parsing error handling
VLSMB
changed the title
|
Please format your code and have a LICENSE before each new file is added |
VLSMB
reviewed
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Replaces calls to printStackTrace with an SLF4J logger in DateUtils.parseDateString so that failures are logged appropriately without throwing uncaught exceptions. On parse failure, the method now logs a warning and returns null. Adds unit test coverage for both successful parsing and failure scenarios to prevent regressions and ensure robustness.
Does this pull request fix one issue?
NONE
Describe how you did it
Introduced a private static SLF4J Logger in DateUtils.
Wrapped the sdf.parse(time) call in a try/catch block; on ParseException, call logger.warn("Failed to parse date string: {}", time, e) and return null.
Wrote JUnit tests verifying that:
A valid date string (e.g. "Wed Sep 10 14:23:45 GMT 2025") returns a non-null Date.
An invalid string (e.g. "not-a-date") yields null and emits a warning.
Describe how to verify it
Run the core module’s tests:
mvn -q -pl spring-ai-alibaba-studio/spring-ai-alibaba-studio-server/spring-ai-alibaba-studio-server-core -am test
Verify all tests pass. Additionally, trigger a failure case in a debugger or by running a small main method to confirm that a warning is logged (rather than a stack trace printed) when parsing an invalid string.