Skip to content

fix(nl2sql): fix isIniialized status #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

fix(nl2sql): fix isIniialized status #2439

merged 1 commit into from
Sep 19, 2025

Conversation

JGoP-L
Copy link
Contributor

@JGoP-L JGoP-L commented Sep 18, 2025 •
edited by VLSMB
Loading

@JGoP-L
- initializeDataSource函数使用setTimeout模拟检查，未真正调用API
424e59b 
- 直接设置isInitialized为true，导致状态不准确
- 用户可能在未初始化状态下误以为已完成初始化进行调试
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/nl2sql SAA nl2sql module label Sep 18, 2025
@JGoP-L JGoP-L changed the title ”检查初始化状态“直接设置isInitialized为true，导致状态不准确 ”检查初始化状态“直接设置isInitialized为true，导致状态不准确#2440 Sep 18, 2025
@yuluo-yx yuluo-yx changed the title ”检查初始化状态“直接设置isInitialized为true，导致状态不准确#2440 optimize: fix isIniialized status Sep 18, 2025
@yuluo-yx yuluo-yx changed the title optimize: fix isIniialized status optimize(nl2sql): fix isIniialized status Sep 18, 2025
@VLSMB VLSMB changed the title optimize(nl2sql): fix isIniialized status fix(nl2sql): fix isIniialized status Sep 18, 2025
zxuexingzhijie
zxuexingzhijie approved these changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@zxuexingzhijie zxuexingzhijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, there seems to be no problem，LGTM！

@VLSMB VLSMB merged commit 0e5c8de into alibaba:main Sep 19, 2025
11 of 17 checks passed
co63oc pushed a commit to co63oc/spring-ai-alibaba that referenced this pull request Sep 19, 2025
@JGoP-L @co63oc
fix(nl2sql): fix isIniialized status (alibaba#2439)
6c8c31f 
- initializeDataSource函数使用setTimeout模拟检查，未真正调用API
- 直接设置isInitialized为true，导致状态不准确
- 用户可能在未初始化状态下误以为已完成初始化进行调试
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

+1 more reviewer

@zxuexingzhijie zxuexingzhijie zxuexingzhijie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/nl2sql SAA nl2sql module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 检查初始化状态直接设置isInitialized为true，导致状态不准确
5 participants
@JGoP-L @CLAassistant @yuluo-yx @zxuexingzhijie @VLSMB