Skip to content

Conversation

junphine
Copy link

增加依赖 spring-ai-alibaba-starter-store-analyticdb 减少重复代码。

修复AbstractDBConnectionPool因为每次创建DataSource,而不能pool的bug。

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

…ba-starter-store-analyticdb for code clean
@CLAassistant
Copy link

CLAassistant commented May 27, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Aias00
✅ yuluo-yx
❌ zhangjunfeng


zhangjunfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/graph SAA Grpah module area/nl2sql SAA nl2sql module labels Jun 1, 2025
@yuluo-yx yuluo-yx changed the title nl2sql LLMService的call增加spring cache支持 feat: nl2sql LLMService的call增加spring cache支持 Jun 1, 2025
@littleahri
Copy link
Contributor

✅ Approved Changes:

  • Redis Cache Integration:
    The addition of Redis dependencies (spring-boot-starter-data-redis, spring-boot-starter-cache) and the implementation of Redis-based caching in LlmService via @Cacheable are well-justified and properly configured through RedisCacheConfig. This enhancement aligns with current performance and scalability goals.

  • JDBC DDL Logic Optimization:
    Improvements made to MysqlJdbcDdl and PostgreJdbcDdl, including better SQL construction and parameter handling in methods like fetchTables and showForeignKeys, help ensure accurate schema information retrieval. These changes are valuable and should be included.

  • DataSource Reuse Optimization:
    The refactoring in AbstractDBConnectionPool to improve dataSource declaration and reuse is a positive change that helps avoid unnecessary object creation and improves resource management.

⚠️ Pending Considerations:

  • AnalyticDB Related Changes:
    The removal of AnalyticDB-related Java files and the package relocation of AnalyticDbVectorStoreProperties are acknowledged. However, as these components will be re-evaluated and abstracted in a future release, it is recommended to leave AnalyticDB-specific code untouched in this PR unless strictly necessary.

📝 Suggested Improvements:

  • License Header Removal:
    The cleanup of redundant or duplicate license headers is appreciated. However, to keep this PR focused on functional changes, it is recommended that such formatting or legal header adjustments be submitted in a separate commit or PR.

  • Minor Code Cleanups:
    Various small improvements to variable names and SQL statements are welcome, but please ensure they are clearly documented or scoped so as not to obscure more significant changes.

✅ Conclusion:

After completing the pending considerations, you can merge

@chickenlj
Copy link
Collaborator

Closed for no response.

@chickenlj chickenlj closed this Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graph SAA Grpah module area/nl2sql SAA nl2sql module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants