Skip to content

Conversation

@xuxiaowei-com-cn
Copy link
Contributor

@xuxiaowei-com-cn xuxiaowei-com-cn commented Dec 16, 2025

Describe what this PR does / why we need it

Does this pull request fix one issue?

#4067
#4068

Describe how you did it

  1. checkstyle
  2. enable RocketMQMessageChannelBinderTest
  3. enable RocketMQInboundChannelAdapter retryTemplate

Describe how to verify it

Special notes for reviews

this.retryTemplate.execute(() -> {
this.sendMessage(message);
return message;
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接把 RecoveryCallback 去除不太合理,改变了原始的行为。可能需要基于 spring7 的内置 retry 看一下解决方案。临时方案可以考虑在 86-87 行的 RetryListener 中扩展 onRetryPolicyExhaustion 方法,并在其中调用 recoveryCallback.recover(null, exception) 来和原有的行为对齐。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Collaborator

@uuuyuqi uuuyuqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uuuyuqi uuuyuqi merged commit 23e7afb into alibaba:2025.1.x Dec 17, 2025
3 checks passed
yingqiaoli8 pushed a commit to yingqiaoli8/spring-cloud-alibaba that referenced this pull request Dec 27, 2025
…ChannelAdapter (alibaba#4162)

chore: restore retry mechanism for message sending in RocketMQInboundChannelAdapter (alibaba#4162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants