Skip to content

✨ add preventive guardrails #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ provider "alicloud" {
region = "cn-shanghai"
}

module "detective_guardrails" {
module "guardrails" {
source = "../../"

detective_guardrails = var.detective_guardrails
preventive_guardrails = var.preventive_guardrails
config_aggreator_name = var.config_aggreator_name
config_aggreator_description = var.config_aggreator_description
config_compliance_pack_name = var.config_compliance_pack_name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,30 @@ detective_guardrails = [
tag_scope_key = ""
tag_scope_value = ""
}
]

preventive_guardrails = [
{
rule_name = "DenyCreateRamRole"
rule_description = "Deny creating RAM role"
policy_document = <<EOF
{
"Statement": [
{
"Action": [
"ram:CreateRole"
],
"Resource": "*",
"Effect": "Deny",
"Condition": {
"StringNotLike": {
"acs:PrincipalARN": "acs:ram:*:*:role/resourcedirectoryaccountaccessrole"
}
}
}
],
"Version": "1"
}
EOF
}
]
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
terraform {
experiments = [module_variable_optional_attrs]
# terraform {
# experiments = [module_variable_optional_attrs]
# }
variable "preventive_guardrails" {
type = list(object({
rule_name = string
rule_description = optional(string)
policy_document = string
target = optional(string)
}))
description = "preventive guardrails, each item in list should have rule_name and policy_document. If target is not specified, it will be set to root_folder_id"
}
variable "detective_guardrails" {
type = list(object({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,32 @@
data "alicloud_account" "current" {
}

#########################################################
# Preventive Controls
#########################################################
data "alicloud_resource_manager_resource_directories" "default" {}

locals {
resource_directory_root_folder_id = "${data.alicloud_resource_manager_resource_directories.default.directories.0.root_folder_id}"
}

module "control_policies" {
source = "./modules/control_policies"

for_each = {
for rule in var.preventive_guardrails: rule.rule_name => rule
}

name = each.value.rule_name
description = can(each.value.rule_description) ? each.value.rule_description : ""
policy_document = each.value.policy_document
target_id = can(each.value.target_id) ? each.value.target_id : local.resource_directory_root_folder_id
}

#########################################################
# Detective Controls
#########################################################

# Retrieve all the accounts in resource directory
data "alicloud_resource_manager_accounts" "accounts" {
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
resource "alicloud_resource_manager_control_policy" "policy" {
control_policy_name = var.name
description = var.description
effect_scope = "RAM"
policy_document = var.policy_document
}

resource "alicloud_resource_manager_control_policy_attachment" "attachment" {
policy_id = alicloud_resource_manager_control_policy.policy.id
target_id = var.target_id
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
variable "name" {
type = string
description = "policy name"
}

variable "description" {
type = string
description = "policy description"
}

variable "policy_document" {
type = string
description = "policy document"
}

variable "target_id" {
type = string
description = "target which policy is applied to"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
terraform {
experiments = [module_variable_optional_attrs]
# terraform {
# experiments = [module_variable_optional_attrs]
# }

variable "preventive_guardrails" {
type = list(object({
rule_name = string
rule_description = optional(string)
policy_document = string
target = optional(string)
}))
description = "preventive guardrails, each item in list should have rule_name and policy_document. If target is not specified, it will be set to root_folder_id"
}
variable "detective_guardrails" {
type = list(object({
Expand Down
Loading