-
Notifications
You must be signed in to change notification settings - Fork 199
Add an External ID param on RAM Role Authentication #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an External ID param on RAM Role Authentication #1153
Conversation
Hi ihar-orca, First and foremost, thank you very much for your contribution! We really appreciate the effort you've put into adding the ability to use external_id on RAM Role Authentication. However, I noticed that there is a test case that hasn't passed. I've attached a screenshot of the error for your reference. Since you have already written some test cases, could you please take a look and update the failing one? If for any reason you are unable to make the changes, we would be happy to assist and make the updates on our end. Thanks again for your valuable contribution! Best regards, sdk-team |
ec9bbdf
to
49c0d91
Compare
hey guys @sdk-team |
@ihar-orca This branch is out-of-date with the base branch, you need merge master manual. |
352f3bf
to
080c99b
Compare
080c99b
to
c25a1d2
Compare
hey @sdk-team @CodeSpaceiiii guys I resolved conflicts and updated the base branch |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
+ Coverage 83.54% 83.56% +0.02%
==========================================
Files 48 48
Lines 4618 4650 +32
==========================================
+ Hits 3858 3886 +28
- Misses 589 593 +4
Partials 171 171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey guys, we want to contribute an ability to use
external_id
on RAM Role Authentication.@sdk-team