Skip to content

Conversation

@Kaev
Copy link

@Kaev Kaev commented Jan 2, 2023

The current description and colorType parameter name is wrong and misleading.

ColorType is a misleading parameter name because it doesn't describe a type, only the amount of colors.
Lipstick and Blush have ColorType = 1 but are using Makeup tints.
Every other overlay with ColorType = 1 uses hair tints.
If it would describe a ColorType, this wouldn't be true.

Also the mentioned overlays with their ColorTypes are wrong. I've tested all ingame and this is the result:

Overlay ID Guessed Overlay Name ColorCount
0 Facial Blemish 0
1 Facial Hair 1
2 Eyebrows 1
3 Age 0
4 Makeup 2
5 Blush 1
6 Complexion 0
7 Sun Damage 0
8 Lipstick 1
9 Freckles 0
10 Chest Hair 1
11 Body Blemish 0
12 Add Body Blemishes 0

I've renamed the parameter and updated the description of setPedHeadOverlayTint so others aren't mislead anymore aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant