Skip to content

feat: add bpos #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add bpos #40

wants to merge 1 commit into from

Conversation

rkrasiuk
Copy link
Member

Description

Add BPOs. Ref: https://eips.ethereum.org/EIPS/eip-7892

Comment on lines +52 to +62
// BPOs: <https://eips.ethereum.org/EIPS/eip-7892>
/// BPO 1
Bpo1,
/// BPO 2
Bpo2,
/// BPO 3
Bpo3,
/// BPO 4
Bpo4,
/// BPO 5
Bpo5,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these aren't useful as dedicated variants because they just are timestamp values that influence active blobparams

adding them as fork enums will cause a lot of friction and imo we can solve this differently because we only need these for forkid, imo we should track them as separate entries in the ChainHardforks struct and add a new classification for them,

struct Bpo {
  name, timestamp
}

that we then can use when we compute the forkid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants