Skip to content

Commit e1c73e7

Browse files
authored
fix: Adjust validation for limit_price of ReplaceOrderRequest (#634)
* fix: adjust validation for ReplaceOrderRequest * fix: remove validation of limit_price in ReplaceOrderRequest * fix: adjust test_replace_order_validate_replace_request
1 parent 5aedabb commit e1c73e7

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

alpaca/trading/requests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,6 @@ def root_validator(cls, values: dict) -> dict:
257257

258258
if (qty is not None) and (qty <= 0):
259259
raise ValueError("qty must be greater than 0")
260-
if (limit_price is not None) and (limit_price <= 0):
261-
raise ValueError("limit_price must be greater than 0")
262260
if (stop_price is not None) and (stop_price <= 0):
263261
raise ValueError("stop_price must be greater than 0")
264262
if (trail is not None) and (trail <= 0):

tests/trading/trading_client/test_order_routes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ def test_replace_order_validate_replace_request() -> None:
298298
# limit_price
299299
ReplaceOrderRequest(limit_price=0.1)
300300
ReplaceOrderRequest(qty=1, limit_price=0.1)
301-
with pytest.raises(ValueError):
302-
ReplaceOrderRequest(limit_price=0)
301+
ReplaceOrderRequest(limit_price=0)
302+
ReplaceOrderRequest(limit_price=-1)
303303

304304
# stop_price
305305
ReplaceOrderRequest(stop_price=0.1)

0 commit comments

Comments
 (0)