Re-enable disabled tests requiring bridge #1083
Conversation
|
Commit: 469d57e SP1 Execution Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1083 +/- ##
==========================================
+ Coverage 72.74% 74.49% +1.75%
==========================================
Files 448 500 +52
Lines 37087 42183 +5096
==========================================
+ Hits 26979 31425 +4446
- Misses 10108 10758 +650
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| print(path) | ||
| priv_keys = [] | ||
| opkeys = sorted( | ||
| filter(lambda file: file.startswith("opkey"), os.listdir(path)), | ||
| key=lambda x: int("".join(filter(str.isdigit, x))), | ||
| ) | ||
| print(opkeys) |
There was a problem hiding this comment.
Are these prints needed? If so then use logging so they get picked up properly.
Edit: oh I see these were from before this PR, it'd be good to convert over the prints in these updated tests
| receipt = wait_until_with_value( | ||
| check_transaction_and_blocks, | ||
| lambda result: not isinstance(result, Exception), | ||
| error_with="Transaction receipt for txid not available", | ||
| timeout=60, | ||
| step=2, | ||
| ) |
There was a problem hiding this comment.
This is basically doing a "wait until EVM tx included in block" operation. If there isn't already waiter for this then can we add it to one so it's available everywhere?
3 participants
Description
for https://alpenlabs.atlassian.net/browse/STR-1727
Type of Change
Notes to Reviewers
Checklist
in the body of this PR.
Related Issues