Skip to content

Conversation

krsnapaudel
Copy link
Contributor

@krsnapaudel krsnapaudel commented Oct 9, 2025

Description

Move CSM state/status types to a new csm-types crate.

This PR was created with help from Cursor AI.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI
    in the body of this PR.

Related Issues

STR-1600

@krsnapaudel krsnapaudel marked this pull request as draft October 9, 2025 15:17
@krsnapaudel krsnapaudel changed the title refactor: move CSM state/status types to a new crate STR-1600: move CSM state/status types to a new crate Oct 9, 2025
@krsnapaudel krsnapaudel requested review from a team as code owners October 9, 2025 15:18
@krsnapaudel krsnapaudel self-assigned this Oct 9, 2025
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (76aef01) to head (f74e08f).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
+ Coverage   74.48%   74.72%   +0.24%     
==========================================
  Files         500      498       -2     
  Lines       42183    41978     -205     
==========================================
- Hits        31420    31369      -51     
+ Misses      10763    10609     -154     
Flag Coverage Δ
functional 53.04% <ø> (+0.41%) ⬆️
unit 53.51% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bin/strata-client/src/helpers.rs 88.37% <ø> (ø)
bin/strata-client/src/rpc_server.rs 72.45% <ø> (-0.56%) ⬇️
bin/strata-dbtool/src/cmd/client_state.rs 0.00% <ø> (ø)
bin/strata-dbtool/src/output/checkpoint.rs 0.00% <ø> (ø)
bin/strata-dbtool/src/output/client_state.rs 0.00% <ø> (ø)
bin/strata-dbtool/src/output/writer.rs 0.00% <ø> (ø)
crates/btcio/src/test_utils.rs 51.95% <ø> (-0.43%) ⬇️
crates/btcio/src/writer/builder.rs 97.35% <ø> (+0.05%) ⬆️
crates/btcio/src/writer/signer.rs 100.00% <ø> (ø)
crates/btcio/src/writer/task.rs 82.74% <ø> (ø)
... and 22 more

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Commit: c100e5e

SP1 Execution Results

program cycles success
EVM EE STF 1,171,170
CL STF 332,306
Checkpoint 2,422

storopoli
storopoli previously approved these changes Oct 9, 2025
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2cf2053

storopoli
storopoli previously approved these changes Oct 10, 2025
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3454f33

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f74e08f

@storopoli storopoli enabled auto-merge October 10, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants