Reorganize a bunch of modules to split them out of primitives #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR might be too large/complicated to merge without breaking other things. In such case, I can rework it.
Much of what was happening here was moving things that were defined in the
primitives
crate to instead be defined in a higher trait, which is then depended on by the primitives crate. There are a few places in the ledger-types PR (which introduced the new state access trait system) where we wanted to use something that was in the primitives crate, but we didn't actually want to depend on the whole primitives crate.One interesting piece is this new
identifiers
crate that contains a bunch of common definitions that are used in very many places.I used Claude pretty extensively to automate resolving import errors in downstream crates.
Type of Change
Notes to Reviewers
Checklist
in the body of this PR.
Related Issues