Skip to content

Commit d41b0d5

Browse files
authored
Merge pull request #385 from alphagov/remove-jasmine-ruby-gem
Remove jasmine ruby gem and its requiring
2 parents 58e7c76 + a7dc7dc commit d41b0d5

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Rakefile

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
require "bundler/gem_tasks"
22
require "rspec/core/rake_task"
3-
require "jasmine"
43

54
RSpec::Core::RakeTask.new(:spec)
65

govuk_tech_docs.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Gem::Specification.new do |spec|
3939
spec.add_dependency "base64" # TODO: remove once middleman-sprockets declares this itself.
4040
spec.add_dependency "bigdecimal" # TODO: remove once activesupport declares this itself.
4141
spec.add_dependency "chronic", "~> 0.10.2"
42+
spec.add_dependency "concurrent-ruby", "1.3.4" # 1.3.5 introduced a change that breaks activesupport, and so middleman
4243
spec.add_dependency "csv" # TODO: remove once tilt declares this itself.
4344
spec.add_dependency "haml", "~> 6.0"
4445
spec.add_dependency "middleman", "~> 4.0"
@@ -57,7 +58,6 @@ Gem::Specification.new do |spec|
5758

5859
spec.add_development_dependency "byebug"
5960
spec.add_development_dependency "capybara", "~> 3.32"
60-
spec.add_development_dependency "jasmine", "~> 3.5"
6161
spec.add_development_dependency "rake", "~> 13.0"
6262
spec.add_development_dependency "rspec", "~> 3.9"
6363
spec.add_development_dependency "rubocop-govuk", "~> 4.10"

0 commit comments

Comments
 (0)