-
Notifications
You must be signed in to change notification settings - Fork 38
Bump govuk frontend to v5.9.0 #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotranchino
approved these changes
Apr 25, 2025
V4.6.0 has a regression middleman/middleman#2818 that fails to render the site, not just config or sitemap
`legacy-organisation-colours` map is getting deprecated, so a new one needs to be used [Deprecation](https://github.com/alphagov/govuk-frontend/releases#:~:text=Migrate%20to%20the%20new%20organisation%20colour%20palette) [New palette released in v5.5.0](https://github.com/alphagov/govuk-frontend/releases#:~:text=in%20our%20documentation.-,New%20features,-We%27ve%20updated%20the)
17ee46c
to
a0fa0ac
Compare
kr8n3r
added a commit
that referenced
this pull request
Apr 30, 2025
Merged
tombye
added a commit
to alphagov/notifications-tech-docs
that referenced
this pull request
Apr 30, 2025
This bumps the tech docs gem to v4.3.0 which brings in [v5.9.0 of GOVUK Frontend](alphagov/tech-docs-gem#390). This also includes the following changes from the gem: - [Fix: Update Rack::File to Rack::Files in test specs](alphagov/tech-docs-gem#394) - [Fix: Use the service link as the start of the path to the favicon images](alphagov/tech-docs-gem#391) - [Allow non-GOV.UK favicon and opengraph assets](alphagov/tech-docs-gem#387) The last change, sets favicon and opengraph images to be sourced from `source/images` so adds defaults for any GOV.UK tech docs. This also bumps all the dependencies to the latest version within their semver range. Check the Gemfile.lock for a full list of these bumps.
maverickvi
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
May 15, 2025
- [Bump govuk-frontend to v5.9.0 and pin middleman to v4.5.1](alphagov#390) - [Fix: Update Rack::File to Rack::Files in test specs](alphagov#394) - [Fix: Use the service link as the start of the path to the favicon images](alphagov#391) by @johnsgp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps govuk-frontend to v5.9.0 and uses the new
$govuk-new-organisation-colours
map aslegacy-organisation-colours
map is getting deprecated.Deprecation
New palette released in v5.5.0
Pins Middleman to v4.5.1 due to a regression in v4.6.0