Use the service link as the start of the path to the favicon images #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @johnsgp thanks for this. We merge a fix for rack into main. You'll need to rebase your branch with main and hopefully test will pass. |
marcotranchino
added a commit
that referenced
this pull request
Apr 25, 2025
johnsgp
force-pushed
the
use-service-link-for-favicon
branch
from
4a083db to
8c2cfea
Compare
johnsgp
changed the title
kr8n3r
reviewed
Apr 25, 2025
kr8n3r
approved these changes
Apr 30, 2025
kr8n3r
added a commit
that referenced
this pull request
Apr 30, 2025
Merged
tombye
added a commit
to alphagov/notifications-tech-docs
that referenced
this pull request
Apr 30, 2025
This bumps the tech docs gem to v4.3.0 which brings in [v5.9.0 of GOVUK Frontend](alphagov/tech-docs-gem#390). This also includes the following changes from the gem: - [Fix: Update Rack::File to Rack::Files in test specs](alphagov/tech-docs-gem#394) - [Fix: Use the service link as the start of the path to the favicon images](alphagov/tech-docs-gem#391) - [Allow non-GOV.UK favicon and opengraph assets](alphagov/tech-docs-gem#387) The last change, sets favicon and opengraph images to be sourced from `source/images` so adds defaults for any GOV.UK tech docs. This also bumps all the dependencies to the latest version within their semver range. Check the Gemfile.lock for a full list of these bumps.
kr8n3r
added a commit
that referenced
this pull request
Apr 30, 2025
- Revert [Fix: Use the service link as the start of the path to the favicon images](#391)
This was referenced Apr 30, 2025
Merged
maverickvi
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
May 15, 2025
- [Bump govuk-frontend to v5.9.0 and pin middleman to v4.5.1](alphagov#390) - [Fix: Update Rack::File to Rack::Files in test specs](alphagov#394) - [Fix: Use the service link as the start of the path to the favicon images](alphagov#391) by @johnsgp
maverickvi
pushed a commit
to hmrc/tech-docs-gem
that referenced
this pull request
May 15, 2025
- Revert [Fix: Use the service link as the start of the path to the favicon images](alphagov#391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s changed
The location of the favicons in the page
<head>has been changed to include theservice_linkfrom the tech-docs.yml configuration file.Identifying a user need
The favicon links added to the core template in v4.0.0 does not work for sites that have a service link. As an example, see the Self Assessment End-to-End Service Guide which has its source in GitHub. There is no favicon on the browser tab because the links look like
<link rel="icon" sizes="48x48" href="/assets/govuk/assets/images/favicon.ico">which resolves to https://developer.service.hmrc.gov.uk/assets/govuk/assets/images/favicon.ico which does not exist. The icon is located at https://developer.service.hmrc.gov.uk/guides/self-assessment-end-to-end-service-guide/assets/govuk/assets/images/favicon.ico. The service_link configuration matches what is missing from the link.
This was raised as an issue by a service guide author. There are 2 dozen or more service guides and roadmaps that either already are or will be affected when updated.