[fix] remove methods causing migration failure on mysql 8 (#258)

daniel-g-wood · web-flow · commit 223010391315 · 2020-11-09T22:09:26.000-05:00
diff --git a/database/migrations/2019_09_25_103421_update_task_results_duration_type.php b/database/migrations/2019_09_25_103421_update_task_results_duration_type.php
@@ -42,7 +42,7 @@ private function migrateDurationValues(bool $toFloat = true)
             ->table(TOTEM_TABLE_PREFIX.'task_results', function (Blueprint $table) use ($toFloat) {
                 // Create new decimal column
                 if ($toFloat) {
-                    $table->decimal('duration', 24, 14)->default(0.0)->charset('')->collation('');
+                    $table->decimal('duration', 24, 14)->default(0.0);
                 } else {
                     $table->string('duration')->default('');
                 }
diff --git a/tests/Feature/ViewDashboardTest.php b/tests/Feature/ViewDashboardTest.php
@@ -2,12 +2,15 @@
 
 namespace Studio\Totem\Tests\Feature;
 
+use Illuminate\Foundation\Testing\RefreshDatabase;
 use Studio\Totem\Result;
 use Studio\Totem\Task;
 use Studio\Totem\Tests\TestCase;
 
 class ViewDashboardTest extends TestCase
 {
+    use RefreshDatabase;
+
     /** @test */
     public function user_can_view_dashboard()
     {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ private function migrateDurationValues(bool $toFloat = true)`
`42`	`42`	`->table(TOTEM_TABLE_PREFIX.'task_results', function (Blueprint $table) use ($toFloat) {`
`43`	`43`	`// Create new decimal column`
`44`	`44`	`if ($toFloat) {`
`45`		`- $table->decimal('duration', 24, 14)->default(0.0)->charset('')->collation('');`
	`45`	`+ $table->decimal('duration', 24, 14)->default(0.0);`
`46`	`46`	`} else {`
`47`	`47`	`$table->string('duration')->default('');`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,12 +2,15 @@`
`2`	`2`
`3`	`3`	`namespace Studio\Totem\Tests\Feature;`
`4`	`4`
	`5`	`+use Illuminate\Foundation\Testing\RefreshDatabase;`
`5`	`6`	`use Studio\Totem\Result;`
`6`	`7`	`use Studio\Totem\Task;`
`7`	`8`	`use Studio\Totem\Tests\TestCase;`
`8`	`9`
`9`	`10`	`class ViewDashboardTest extends TestCase`
`10`	`11`	`{`
	`12`	`+ use RefreshDatabase;`
	`13`	`+`
`11`	`14`	`/** @test */`
`12`	`15`	`public function user_can_view_dashboard()`
`13`	`16`	`{`