Enhance team registration to check for duplicate admin emails case insensitively

- Updated the team registration logic to ensure that admin email checks are case insensitive, preventing duplicate registrations with varying cases.
- Added new tests to verify that registration fails when attempting to register a team with an admin email that matches an existing one, regardless of case.

Author: PhiRho

app/api/teams.py

@@ -1,5 +1,6 @@
 from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.orm import Session
+from sqlalchemy import func
 from typing import List, Optional
 from datetime import datetime, UTC
 import logging
@@ -33,8 +34,8 @@ async def register_team(
     """
     Register a new team. This endpoint is publicly accessible.
     """
-    # Check if team email already exists
-    db_team = db.query(DBTeam).filter(DBTeam.admin_email == team.admin_email).first()
+    # Check if team email already exists (case insensitive)
+    db_team = db.query(DBTeam).filter(func.lower(DBTeam.admin_email) == func.lower(team.admin_email)).first()
     if db_team:
         raise HTTPException(
             status_code=status.HTTP_400_BAD_REQUEST,

tests/test_teams.py

@@ -57,6 +57,70 @@ def test_register_team_duplicate_admin_email(client, db):
     assert response.status_code == 400
     assert response.json()["detail"] == "Email already registered"
 
+def test_register_team_duplicate_admin_email_case_insensitive(client, db):
+    """
+    Given a team with admin_email "existing@example.com" exists
+    When registering a new team with admin_email "EXISTING@EXAMPLE.COM"
+    Then the registration should fail with "Email already registered" error
+    """
+    # First, create a team
+    team = DBTeam(
+        name="Existing Team",
+        admin_email="existing@example.com",
+        phone="1234567890",
+        billing_address="123 Test St, Test City, 12345",
+        is_active=True,
+        created_at=datetime.now(UTC)
+    )
+    db.add(team)
+    db.commit()
+    db.refresh(team)
+
+    # Try to register a new team with the same admin_email but different case
+    response = client.post(
+        "/teams/",
+        json={
+            "name": "New Team",
+            "admin_email": "EXISTING@EXAMPLE.COM",
+            "phone": "0987654321",
+            "billing_address": "456 New St, New City, 54321"
+        }
+    )
+    assert response.status_code == 400
+    assert response.json()["detail"] == "Email already registered"
+
+def test_register_team_duplicate_admin_email_case_insensitive_reverse(client, db):
+    """
+    Given a team with admin_email "EXISTING@EXAMPLE.COM" exists
+    When registering a new team with admin_email "existing@example.com"
+    Then the registration should fail with "Email already registered" error
+    """
+    # First, create a team with uppercase email
+    team = DBTeam(
+        name="Existing Team",
+        admin_email="EXISTING@EXAMPLE.COM",
+        phone="1234567890",
+        billing_address="123 Test St, Test City, 12345",
+        is_active=True,
+        created_at=datetime.now(UTC)
+    )
+    db.add(team)
+    db.commit()
+    db.refresh(team)
+
+    # Try to register a new team with the same admin_email but lowercase
+    response = client.post(
+        "/teams/",
+        json={
+            "name": "New Team",
+            "admin_email": "existing@example.com",
+            "phone": "0987654321",
+            "billing_address": "456 New St, New City, 54321"
+        }
+    )
+    assert response.status_code == 400
+    assert response.json()["detail"] == "Email already registered"
+
 def test_list_teams(client, admin_token, db, test_team):
     """Test listing all teams (admin only)"""
     # List teams as admin