feat: support to prevent database being dropped when consumers removed #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomoko
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we move towards deprecating this operator and move towards https://github.com/uselagoon/dbaas-controller, there needs to be a way to flag a consumer to not drop the database from the provider when the resource is deleted.
As we are deprecating this service, I opted to use a label to handle this. The
build-deploy-toolwill add this label when performing a migration from aXConsumerto aDatabaseRequest, and then at the end of a deployment, when theXConsumerwould be removed, the database associated would remain while the linked services would be removed.To prevent the database from being dropped, the existence of this label
dbaas.amazee.io/no-drop-databasewith any value will do.Also some small adjustments to some message formatting.