GraphQL Enhancements#94
Draft
LoganSmithDarkLight wants to merge 2 commits intoamericanexpress:mainfrom
Draft
Conversation
|
lpsmit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
This pull request is stale because it has been open 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetchye currently creates a new cache for every GraphQL query fired (assuming the queries have minor differences). Consider the following scenarios:
This change aims to prevent duplication in the way Fetchye requests data from GraphQL APIs. The goals of this change are as follows:
The following goals are accomplished by introducing these changes:
The following assumptions are made to ensure this process can function:
Potential issues identified with this approach:
Thank you for your time in reviewing this! If you have any concerns or questions please leave a comment. I also have a working demo of this change if you would like to see it. Please reach out to me if so.