fix: handled error from get_username gracefully instead of panicking #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashupednekar
commented
Oct 6, 2024
ashupednekar
commented
- instead of unwrapping on get_username result, propagating the error properly to main so that it gracefully fails instead of panicking
amritghimire
requested changes
Oct 8, 2024
| fn check_config_exists() -> bool { | ||
| fs::metadata(get_config_file_name()).is_ok() | ||
| fn check_config_exists() -> Result<bool> { | ||
| Ok(fs::metadata(get_config_file_name()).is_ok()) |
There was a problem hiding this comment.
Why is this necessary if Ok is returned always?
There was a problem hiding this comment.
It's just to propagate the error from create config all the way to main, so it doesn't panic
Also, in the future there's value in adding a proper cli library like clap
|
Can you fix the rust fmt? |
|
amritghimire
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.