Using micromamba and an env file #616
Conversation
|
OK, thanks! Let me know when you think it's ready to merge. |
|
@oeway I've add test containers, this will now check if the hypha container can come only and respond to a get request. This should mean that if we break the image at all the image at all the tests will fail. It doesn't then do any further tests but that can be added as needs. |
ctr26
force-pushed
the
docker_permissions
branch
from
2bbe517 to
e32de69
Compare
|
Not ready yet, still some permissions issues |
|
@ctr26 Have you fixed the permission issue? |
|
Thanks for the reminder will fix by tomorrow |
ctr26
force-pushed
the
docker_permissions
branch
from
2472a19 to
c4e3f5a
Compare
ctr26
force-pushed
the
docker_permissions
branch
from
c4e3f5a to
f8b1f1b
Compare
| build: . | ||
| image: amun-ai/hypha | ||
| container_name: hypha | ||
| command: --port 9520 --host=0.0.0.0 |
There was a problem hiding this comment.
should this be more like the CMD in the Dockerfile ?
There was a problem hiding this comment.
I think you are right, we have it already
Line 79 in 81ced64
There was a problem hiding this comment.
Yeah the entry point in the dockerfile has it already. This PR was going to add in the permissions fix as well, but I believe @oeway fixed that already during the time this PR has been open. I've rebased on the main branch and now this PR is mostly trying to put some container testing in place.
I'm now just checking to see if bumping the hypha version downstream fixes the permissions issues.
P.s
I think the default port on the original server this ran on was 9000 and that then became the port for the k8s cluster etc etc.
There was a problem hiding this comment.
Hi @ctr26 I think the latest one should work for non-privileged rancher cluster, we have tested it with the helm chart included in the repo: https://github.com/amun-ai/hypha/tree/main/helm-charts
So maybe we can close this PR?
There was a problem hiding this comment.
Yep, I saw that you tried to fix the permission. I'm now updating the bioengine image with the newest hypha to make the egi stuff work.
I think it's a good idea for the docker image testing that I've put here to still be added as it'll be useful for the future.
But otherwise this PR is now rebased to use your dockerfile
@oeway
This is my way of fixing the docker permissions. It uses the mamba image which is well documented for settings permissions and setting working directories properly.
As of yet untested (Will test soon)