Dev adrv9001 sel clk zcu102 #1931
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AndreiGrozav <andrei.grozav@analog.com>
Add info regarding selectable Tx clock source during build time. Signed-off-by: AndreiGrozav <andrei.grozav@analog.com>
AndreiGrozav
requested review from
IuliaCMoldovan,
LBFFilho,
StancaPop and
gastmaier
as code owners
StancaPop
requested changes
Oct 22, 2025
| # | ||
| # e.g. | ||
| # make USE_RX_CLK_FOR_TX1=0 USE_RX_CLK_FOR_TX2=0 | ||
| # |
There was a problem hiding this comment.
Even though it might sound redundant, I would add a line with the parameter name and description, before the available value options (for both USE_RX_CLK_FOR_TX1 and USE_RX_CLK_FOR_TX2).
Keep the comments section uninterrupted by tcl commands and "set" the parameters after the comments section.
Here is a good example: https://github.com/analogdevicesinc/hdl/blob/main/projects/ad4630_fmc/zed/system_project.tcl#L15-L20
|
|
||
| set CMOS_LVDS_N [get_env_param CMOS_LVDS_N 1] | ||
|
|
||
| # 0 = Tx1 SSI reference clock |
There was a problem hiding this comment.
Same here, add param name & description before the enumerated possible values.
| # | ||
| # e.g. | ||
| # make USE_RX_CLK_FOR_TX1=0 USE_RX_CLK_FOR_TX2=0 | ||
| # |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add build time, selectable, Tx channel interface clock selection.
PR Type
PR Checklist