-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Description
if (lineCount > sizeof(RxGainTable) / sizeof(struct RxGainTableEntry)) |
if (lineCount > sizeof(ORxGainTable) / sizeof(struct ORxGainTableEntry)) |
if (lineCount > sizeof(RxGainTable_GainCompensated) / sizeof( |
shouldnt it be
lineCount >= sizeof(...)
?, otherwise you index with the list length which is obviously wrong.
Also here:
no-OS/drivers/rf-transceiver/navassa/devices/adrv9001/public/src/adi_adrv9001_utilities.c
Line 205 in ea88102
(gainIndex > ADI_ADRV9001_ORX_GAIN_INDEX_MAX)) |
gainIndex >= ...
, other wise you end up calling adi_hal_RxGainTableEntryGet
in the next iteration with an out of bound lineCount
, (which you do not properly catch in your example). I noticed this because my implementation of adi_hal_RxGainTableEntryGet
is being passed out of bounds lineCount
.
cc @buha
Metadata
Metadata
Assignees
Labels
No labels