[Draft] EVAL_POWRMS: IIO and screen for rev-B: #2764
Conversation
| static int m24512_write_raw(struct m24512_dev *dev, uint16_t addr, | ||
| const uint8_t *data, uint16_t len); | ||
|
|
||
| /******************************************************************************/ |
There was a problem hiding this comment.
please use a recursive tool to remove all these delimiters, see an example here:
88083db
There was a problem hiding this comment.
I will solve this in a different PR, as soon this driver will be accepted, I will drop these files from this project
| return -EINVAL; | ||
|
|
||
| ret = no_os_i2c_write(dev->i2c_desc, ®_addr, 1, 1); | ||
| ret = no_os_i2c_write(dev->i2c_desc, ®_addr, 1, 0); |
There was a problem hiding this comment.
put the driver changes in a separate commit
| #include "no_os_util.h" | ||
| #include "mxc_delay.h" | ||
| #include "mxc_sys.h" | ||
| #include "lvgl.h" |
There was a problem hiding this comment.
put these maxim_delay changes in a separate commit
There was a problem hiding this comment.
This doesn't look good. You're making the maxim delay driver dependent on an external library. I think the proper way of implementing this is to allow the user to register a function which will be called in the systick handler.
There was a problem hiding this comment.
these are just some preliminary solutions, just for a working project... anything outside the project file will be dropped upon converting this into PR
|
the rest looks good to me but run astyle and fix the documentation |
rbudai98
changed the title
- drivers: maxim_delay.c: include lvgl comulsory callback function - add button implementation for BACk, NEXT and ENTER - added blank screen upon en_latch off - buttons implemented - print out real-time VIN0 and VIN1 from adc - custom initializaiton process - added tinyIIOD for vin0 vin1, vrmsf, vrmsr channels, with global attrbutes for impedance and frequency - modified general screen llgic to work in parallel with iiod - added m24512 memory init and test - TODO: add lookup table and use that to calc P0 and P1 Signed-off-by: rbudai98 <robert.budai@analog.com>
rbudai98
force-pushed
the
staging/eval-powrms
branch
from
5eb66f6 to
b72d301
Compare
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist