drivers:dac:ad5710r: Add support for AD5710r #2784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaikiranGudla
requested review from
CiprianRegus,
amiclaus,
buha,
danmois,
dbogdan and
rbolboac
as code owners
SaikiranGudla
force-pushed
the
ad5710r-support
branch
from
305896d to
f137700
Compare
amiclaus
reviewed
Oct 24, 2025
drivers/dac/ad5710r/ad5710r.c
Outdated
|
|
||
| short_instr = data->spi_cfg->short_instr; | ||
| sign = desc->spi_cfg.addr_asc ? 1 : -1; | ||
| inc = 0 ; |
Contributor
There was a problem hiding this comment.
these should be initialized at declaration. reduces code duplication.
| return ret; | ||
|
|
||
| desc->range = range_sel; | ||
| return 0; |
Contributor
There was a problem hiding this comment.
preffered an empty line before the last return of the function. check all occurences.
Added support for AD5710R DAC driver. Signed-off-by: SGudla <Saikiran.Gudla@analog.com>
SaikiranGudla
force-pushed
the
ad5710r-support
branch
2 times, most recently
from
61ececb to
71527b9
Compare
Collaborator
Author
Change log: Addressed review comments and added doc |
SaikiranGudla
force-pushed
the
ad5710r-support
branch
2 times, most recently
from
06ffcc1 to
f88cf20
Compare
Add rst documentation file for AD5710r driver. Signed-off-by: SGudla <Saikiran.Gudla@analog.com>
SaikiranGudla
force-pushed
the
ad5710r-support
branch
from
f88cf20 to
ec12c39
Compare
Collaborator
Author
|
@amiclaus, I've addressed review comments and added doc. May I know if this is good to be merged now? |
amiclaus
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for AD5710R DAC driver.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist