Skip to content

Conversation

@SeptimiuVana
Copy link
Collaborator

No description provided.

Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
Signed-off-by: SeptimiuVana <vana.septimiu@analog.com>
include/imuanalyzer/imuanalyzersettings.hpp
src/datavisualizer.cpp
include/imuanalyzer/datavisualizer.hpp
# ${PROJECT_RESOURCES}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comented code

QVector<double> xLinePoint{90, 90};
QVector<double> yLinePoint{3, 3};
PlotWidget *plotWidget;
QwtPlotCurve *point;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private var names should all start with "m_" for consistency

Q_OBJECT
public:
BubbleLevelRenderer(QWidget *parent = nullptr);
//~BubbleLevelRenderer();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

private:
data3P m_rot, m_deltaRot;
float temp = 0.0f;
QPlainTextEdit *m_accelTextBox, *m_linearATextBox, *m_magnTextBox, *m_tempTextBox;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m_magnTextBox is declared but not used


private:
data3P m_rot, m_deltaRot;
float temp = 0.0f;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp, m_rot and m_deltaRot are declared but not used

#include <Qt3DRender/QRenderStateSet>
#include <Qt3DExtras/QText2DEntity>
#include <Qt3DCore/QEntity>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some includes are not used and should be removed

Q_OBJECT
public:
SceneRenderer(QWidget *parent = nullptr);
// ~SceneRenderer();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

#include <pluginbase/messagebroker.h>
#include <pluginbase/preferences.h>
#include <qdebug.h>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some includes are not used and should be removed

data3P m_rot = {0.0f, 0.0f, 0.0f};
data3P m_dist = {0.0f, 0.0f, 0.0f};

std::thread t;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private var names should all start with "m_" for consistency

Qt3DExtras::QPhongMaterial *m_cubeMaterial;
Qt3DExtras::QPhongMaterial *m_planeMaterial;

Qt3DCore::QEntity *cubeEntity;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private var names should all start with "m_" for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants