Skip to content

Commit 938aaed

Browse files
author
Cristoforo Cervino
committed
drops php 7.4 tests
1 parent 1bbd95d commit 938aaed

File tree

7 files changed

+7
-55
lines changed

7 files changed

+7
-55
lines changed

.github/workflows/workflow.yml

-48
Original file line numberDiff line numberDiff line change
@@ -2,40 +2,13 @@ name: shared-query-builder-CI
22
on:
33
[push, pull_request]
44
jobs:
5-
build-php-7-4:
6-
runs-on: ubuntu-latest
7-
steps:
8-
- uses: shivammathur/setup-php@v2
9-
with:
10-
php-version: '7.4'
11-
- uses: actions/checkout@v2
12-
- name: composer install
13-
run: composer install
14-
155
build-php-8:
166
runs-on: ubuntu-latest
177
steps:
188
- uses: actions/checkout@v2
199
- name: composer install
2010
run: composer install
2111

22-
check-code-php-7-4:
23-
runs-on: ubuntu-latest
24-
needs: [ build-php-7-4 ]
25-
steps:
26-
- uses: shivammathur/setup-php@v2
27-
with:
28-
php-version: '7.4'
29-
- uses: actions/checkout@v2
30-
- name: composer install
31-
run: composer install
32-
33-
- name: cs-check
34-
run: composer cs-check
35-
36-
- name: phpstan
37-
run: composer phpstan
38-
3912
check-code-php-8:
4013
runs-on: ubuntu-latest
4114
needs: [ build-php-8 ]
@@ -50,27 +23,6 @@ jobs:
5023
- name: phpstan
5124
run: composer phpstan
5225

53-
tests-php-7-4:
54-
runs-on: ubuntu-latest
55-
needs: [ build-php-7-4 ]
56-
steps:
57-
- uses: shivammathur/setup-php@v2
58-
with:
59-
php-version: '7.4'
60-
- uses: actions/checkout@v2
61-
62-
- name: composer install
63-
run: composer install
64-
65-
- name: setting mysql
66-
run: |
67-
sudo systemctl enable mysql.service
68-
sudo systemctl start mysql.service
69-
mysql -uroot -proot -h localhost -e "CREATE DATABASE test CHARACTER SET utf8 COLLATE utf8_general_ci;"
70-
71-
- name: phpunit
72-
run: composer phpunit
73-
7426
tests-php-8:
7527
runs-on: ubuntu-latest
7628
needs: [ build-php-8 ]

tests/Model/Address.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class Address
1414
#[ORM\GeneratedValue]
1515
#[ORM\Column(Types::INTEGER)]
1616
private ?int $id = null;
17-
#[ORM\Column(Types::STRING, null, null, null, null, false, true)]
17+
#[ORM\Column(Types::STRING, nullable: true)]
1818
private ?string $name = null;
1919

2020
public function getId(): ?int

tests/Model/Document.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class Document
1515
#[ORM\Column(Types::INTEGER)]
1616
private ?int $id = null;
1717

18-
#[ORM\Column(Types::STRING, null, null, null, null, false, true)]
18+
#[ORM\Column(Types::STRING, nullable: true)]
1919
private ?string $name = null;
2020

2121
public function getId(): ?int

tests/Model/Employee.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
class Employee extends Person
1313
{
1414
/** @var Collection<int, Paper> */
15-
#[ORM\OneToMany('employee', Paper::class)]
15+
#[ORM\OneToMany(Paper::class, mappedBy: 'employee')]
1616
private Collection $papers;
1717

1818
public function __construct()

tests/Model/Organization.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class Organization
2424
#[ORM\ManyToMany(Person::class)]
2525
private Collection $persons;
2626

27-
#[ORM\Column(Types::STRING, null, null, null, null, false, true)]
27+
#[ORM\Column(Types::STRING, nullable: true)]
2828
private ?string $name = null;
2929

3030
public function __construct()

tests/Model/Paper.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ class Paper
1717
#[ORM\Column(Types::INTEGER)]
1818
private ?int $id = null;
1919

20-
#[ORM\Column(Types::STRING, null, null, null, null, false, true)]
20+
#[ORM\Column(Types::STRING, nullable: true)]
2121
private ?string $name = null;
2222

2323
/** @var Collection<int, Employee> */
24-
#[ORM\OneToMany('papers', Employee::class)]
24+
#[ORM\OneToMany(Employee::class, mappedBy: 'papers')]
2525
private Collection $employees;
2626

2727
#[ORM\ManyToOne(Document::class)]

tests/Model/Person.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class Person
1616
#[ORM\Column(Types::INTEGER)]
1717
private ?int $id = null;
1818

19-
#[ORM\Column(Types::STRING, null, null, null, null, false, true)]
19+
#[ORM\Column(Types::STRING, nullable: true)]
2020
private ?string $name = null;
2121

2222
public function getId(): ?int

0 commit comments

Comments
 (0)