Merge pull request #11 from andresWeitzel/security-03-fix-hard-coded-credentials-test

security-03-fix-hard-coded-credentials-test

Author: andresWeitzel

.env

@@ -9,3 +9,10 @@ API_GRPC_IP_ENDPOINT_ADDRESS_NAME_URL = '/api/v1/grpc-ip/'
 
 # Whois config
 WHOIS_BASE_URL = "https://ipwho.is/"
+
+# Mock testing
+MOCK_STRING_01 = ""
+MOCK_NUMBER_01 = 8123891273812
+MOCK_INVALID_IP_01 = "192.77"
+MOCK_VALID_IP_01 = "8.8.8.8"
+MOCK_OBJECT_VALUE_01 = "mock_object_value"

jest.config.js

@@ -0,0 +1,7 @@
+
+//For using environment variables with .env
+const dotenv = require("dotenv");
+
+module.exports = {
+    setupFiles: ["dotenv/config"]
+}

src/test/unit-test/api-integration/helpers/format/address.test.js

@@ -4,7 +4,8 @@ const {
   splitAddressByLastDot,
 } = require("../../../../../api-integration/helpers/format/address");
 //Const
-const MOCK_STRING_VALUE = "";
+const MOCK_STRING_01 = process.env.MOCK_STRING_01;
+const MOCK_NUMBER_01 = parseInt(process.env.MOCK_NUMBER_01);
 //Vars
 let msg;
 let splitAddressByLastDotResult;
@@ -20,26 +21,24 @@ describe("- splitAddressByLastDot helper (Unit Test)", () => {
     msg =
       "Should return a object type if a valid argument is passed (This function expects a single argument)";
     it(msg, async () => {
-      splitAddressByLastDotResult = await splitAddressByLastDot(
-        MOCK_STRING_VALUE
-      );
+      splitAddressByLastDotResult = await splitAddressByLastDot(MOCK_STRING_01);
       await expect(typeof splitAddressByLastDotResult == "object").toBe(true);
     });
 
     msg =
       "Should return a object type if two valid arguments are passed (This function expects a single argument)";
     it(msg, async () => {
       splitAddressByLastDotResult = await splitAddressByLastDot(
-        MOCK_STRING_VALUE,
-        MOCK_STRING_VALUE
+        MOCK_STRING_01,
+        MOCK_STRING_01
       );
       await expect(typeof splitAddressByLastDotResult == "object").toBe(true);
     });
- 
+
     msg =
       "Should return a string type if an invalid argument is passed (This function expects a single argument)";
     it(msg, async () => {
-      splitAddressByLastDotResult = await splitAddressByLastDot(122212131);
+      splitAddressByLastDotResult = await splitAddressByLastDot(MOCK_NUMBER_01);
       await expect(typeof splitAddressByLastDotResult == "string").toBe(true);
     });
 

src/test/unit-test/api-integration/helpers/request/get-data-from-address.test.js

@@ -4,73 +4,74 @@ const {
   getDataFromSpecificAddress,
 } = require("../../../../../api-integration/helpers/request/get-data-from-address");
 //Const
-const MOCK_OBJECT_VALUE = { mock_object_key: "mock_object_value" };
-const MOCK_INVALID_IP_VALUE = "192.77";
-const MOCK_VALID_IP_VALUE = "8.8.8.8";
+const MOCK_OBJECT_KEY_01 = process.env.MOCK_OBJECT_KEY_01;
+const MOCK_OBJECT_01 = { mock_object_key: MOCK_OBJECT_KEY_01 };
+const MOCK_INVALID_IP_VALUE_01 = process.env.MOCK_INVALID_IP_01;
+const MOCK_VALID_IP_VALUE_01 = process.env.MOCK_VALID_IP_01;
 //Vars
 let msg;
 let getDataFromSpecificAddressResult;
 
 describe("- getDataFromSpecificAddress helper (Unit Test)", () => {
   describe("1) Check cases for arguments.", () => {
     msg =
-      "Should return a string type if no arguments are passed (This function expects a single argument of string type)";
+      "Should return a object type if no arguments are passed (This function expects a single argument of string type)";
     it(msg, async () => {
       getDataFromSpecificAddressResult = await getDataFromSpecificAddress();
-      await expect(typeof getDataFromSpecificAddressResult == "string").toBe(
+      await expect(typeof getDataFromSpecificAddressResult == "object").toBe(
         true
       );
     });
 
     msg =
-      "Should return a string type if not string argument is passed (This function expects a single argument of string type)";
+      "Should return a object type if not string argument is passed (This function expects a single argument of string type)";
     it(msg, async () => {
       getDataFromSpecificAddressResult = await getDataFromSpecificAddress(
-        MOCK_OBJECT_VALUE
+        MOCK_OBJECT_01
       );
-      await expect(typeof getDataFromSpecificAddressResult == "string").toBe(
+      await expect(typeof getDataFromSpecificAddressResult == "object").toBe(
         true
       );
     });
 
     msg =
-      "Should return a string type if an invalid ip is passed (This function expects a single argument of string type)";
+      "Should return a object type if an invalid ip is passed (This function expects a single argument of string type)";
     it(msg, async () => {
       getDataFromSpecificAddressResult = await getDataFromSpecificAddress(
-        MOCK_INVALID_IP_VALUE
+        MOCK_INVALID_IP_VALUE_01
       );
-      await expect(typeof getDataFromSpecificAddressResult == "string").toBe(
+      await expect(typeof getDataFromSpecificAddressResult == "object").toBe(
         true
       );
     });
 
     msg =
-      "Should return a string type if a valid ip is passed (This function expects a single argument of string type)";
+      "Should return a object type if a valid ip is passed (This function expects a single argument of string type)";
     it(msg, async () => {
       getDataFromSpecificAddressResult = await getDataFromSpecificAddress(
-        MOCK_VALID_IP_VALUE
+        MOCK_VALID_IP_VALUE_01
       );
-      await expect(typeof getDataFromSpecificAddressResult == "string").toBe(
+      await expect(typeof getDataFromSpecificAddressResult == "object").toBe(
         true
       );
     });
 
     msg =
-      "Should return a string type if a null value is passed (This function expects a single argument of string type)";
+      "Should return a object type if a null value is passed (This function expects a single argument of string type)";
     it(msg, async () => {
       getDataFromSpecificAddressResult = await getDataFromSpecificAddress(null);
-      await expect(typeof getDataFromSpecificAddressResult == "string").toBe(
+      await expect(typeof getDataFromSpecificAddressResult == "object").toBe(
         true
       );
     });
 
     msg =
-      "Should return a string type if an undefined value is passed (This function expects a single argument of string type)";
+      "Should return a object type if an undefined value is passed (This function expects a single argument of string type)";
     it(msg, async () => {
       getDataFromSpecificAddressResult = await getDataFromSpecificAddress(
         undefined
       );
-      await expect(typeof getDataFromSpecificAddressResult == "string").toBe(
+      await expect(typeof getDataFromSpecificAddressResult == "object").toBe(
         true
       );
     });
@@ -119,18 +120,13 @@ describe("- getDataFromSpecificAddress helper (Unit Test)", () => {
     });
 
     msg =
-      "Should return a string type with 'ERROR in getDataFromSpecificAddress helper function.' value if a new Error is passed for arguments.";
+      "Should return a object type if a new Error is passed for arguments.";
     it(msg, async () => {
       let newError = new Error();
-      const GET_DATA_FROM_SPECIFIC_ADDRESS_ERROR_NAME =
-        "ERROR in getDataFromSpecificAddress helper function.";
-
       getDataFromSpecificAddressResult = await getDataFromSpecificAddress(
         newError
       );
-      await expect(getDataFromSpecificAddressResult).toMatch(
-        GET_DATA_FROM_SPECIFIC_ADDRESS_ERROR_NAME
-      );
+      await expect(typeof getDataFromSpecificAddressResult  == "object");
     });
   });
 });