Skip to content

Commit 86ac3ab

Browse files
authored
Fix flaky ExistsQueryBuilderTests.testToQuery (opensearch-project#18995)
* Fix flaky ExistsQueryBuilderTests.testToQuery Test was generating field patterns that matched raw.derived_keyword, which doesnt support exists queries. Fixed by replacing problematic patterns with TEXT_FIELD_NAME. Fixes opensearch-project#18724 Signed-off-by: Atri Sharma <atri.jiit@gmail.com> * Revert CHANGELOG changes Signed-off-by: Atri Sharma <atri.jiit@gmail.com> --------- Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
1 parent f967a72 commit 86ac3ab

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

server/src/test/java/org/opensearch/index/query/ExistsQueryBuilderTests.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,20 @@ protected ExistsQueryBuilder doCreateTestQueryBuilder() {
8787
} else {
8888
fieldPattern = randomAlphaOfLengthBetween(1, 10);
8989
}
90+
91+
// Avoid patterns that would match the derived field "raw.derived_keyword"
92+
// which doesn't support exists queries
93+
if (fieldPattern.startsWith("raw")) {
94+
fieldPattern = TEXT_FIELD_NAME;
95+
}
96+
9097
// also sometimes test wildcard patterns
9198
if (randomBoolean()) {
92-
if (randomBoolean()) {
99+
if (randomBoolean() && !fieldPattern.equals("r") && !fieldPattern.equals("ra")) {
93100
fieldPattern = fieldPattern + "*";
94101
}
95102
}
103+
96104
return new ExistsQueryBuilder(fieldPattern);
97105
}
98106

0 commit comments

Comments
 (0)