Skip to content

Typo in isgreater #21

Open
Open
@tpgillam

Description

@tpgillam

function isgreater(a, b)
isless(b, a) || isequal(a, b)
end

Should be isgreater(a, b) = isless(b, a).

It's correct in the README though!

* `isgreater(a, b) = isless(b, a)`

In practice I think the tests don't catch this because they're only looking at the implementations of findall and findlast for these on UniqueSortIndex, which doesn't actually depend on the implementation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions