fix(material/slide-toggle): increase slide toggle ripple touch target #31469
Conversation
adolgachev
requested review from
crisbeto,
wagnermaciel and
andrewseguin
and removed request for
a team,
crisbeto and
wagnermaciel
adolgachev
added
Accessibility
|
Deployed dev-app for 01c65da to: https://ng-dev-previews-comp--pr-angular-components-31469-dev-xl6bs3gm.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
| -1: 36px, | ||
| -2: 32px, | ||
| -3: 28px, | ||
| 0: 48px, |
There was a problem hiding this comment.
I don't think that this is the right way to solve the issue, it just makes the ripple larger and ripples are meant to be decorative. The way we handle the touch target in other components is to have a transparent div that is always at least 48x48 and isn't affected by density. See .mat-mdc-radio-touch-target as an example.
There was a problem hiding this comment.
This was suggested by @andrewseguin actually instead of #31178.
I'll take a look at mat-mdc-radio-touch-target.
Another issue with increasing the ripple is it can add a scrollbar when the toggle is at the bottom, breaking quite a few screenshot tests.
There was a problem hiding this comment.
I think that #31178 is the proper way to do it.
There was a problem hiding this comment.
That does actually look like a simpler and better solution that either of the others. Started at #31486.
No description provided.